Skip to content

docs(instruction-placement): align MS-13 cells with the re-pinned quote - #11786

Merged
kyle-sexton merged 2 commits into
mainfrom
docs/6916-w5-instruction-placement-pointers
Nov 1, 2026
Merged

kyle-sexton merged 2 commits into
mainfrom
docs/6916-w5-instruction-placement-pointers

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Refs: #6916

Summary

Wave 5 findings from the #6916 drift sweep in the instruction-placement plugin (wave G, 2 findings). Each was re-read at main b0e26671d3, and its upstream quote was re-read raw on 2026-11-01.

Fix

  • context/verified-mechanics.md: the surface table's root CLAUDE.md cell and the MS-13 row now carry the managed-settings case: an omitClaudeMd agent defined in managed settings loads no instruction file. The MS-13 quote in mechanics-sources.tsv already recorded it. MS-13's recheck trigger now also covers what an omitClaudeMd agent keeps.
  • skills/migrate/reference/verification.md: the probe keeps --model sonnet, with a one-line reason and a pointer to model-config#model-aliases.
  • Patch fragment for instruction-placement.

Verification

  • scripts/check-affected.sh --tests on the committed head: 14 passed, 2 skipped.

Remaining on #6916

This pull request delivers one plugin's share of wave 5. Still open on the issue:

Related

🤖 Generated with Claude Code

Wave 5 findings from the #6916 drift sweep in the instruction-placement
plugin. The surface table and MS-13 row carry the managed-settings case
the quote already records, with a wider recheck trigger, and the migrate
probe states why it runs on sonnet.

Refs: #6916

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 1, 2026 01:56
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T01:57:49.208637Z 15ab9d3 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 8270f9685879bde1b8bbb722118438bc2f5e4d0e: read 3 of 3 changed file(s); 0 finding(s), 0 as inline comments.

Security review: PR #11786

No security issues found.

I read every hunk of all 3 changed files in .claude-lane/pr.diff:

  • .changes/instruction-placement/docs-6916-w5-ip-pointers-c3f60a18.md is a new patch changelog fragment containing only prose.
  • plugins/instruction-placement/context/verified-mechanics.md changes reference documentation. The surface-table cell and the MS-13 row now say that an omitClaudeMd agent defined in managed settings loads no instruction file, and MS-13's recheck trigger gets wider. Both edits add clarification. Neither removes or softens a rule.
  • plugins/instruction-placement/skills/migrate/reference/verification.md adds a sentence explaining why the probe uses --model sonnet, plus a pointer to the docs. The probe command and its --allowedTools Read scope are unchanged.

Why this has no security-relevant surface:

  • None of the changed files matches the TRUSTED PATHS globs.
  • The diff touches no plugin manifest, workflow, action or trust control.
  • Instruction surfaces: nothing in the diff deletes, narrows or softens a standing instruction. The skill reference file only gains explanatory text.
  • Embedded instructions: the PR context contains no text aimed at the review lane.

critical-findings: 0

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

claude-review reviewed 8270f9685879bde1b8bbb722118438bc2f5e4d0e: read 3 of 3 changed file(s); 0 finding(s), 0 as inline comments.

Code review: no findings

I read every hunk in all 3 changed files. No changed file matches a trusted-path glob.

What changed

  • plugins/instruction-placement/context/verified-mechanics.md: the root CLAUDE.md subagent cell and the MS-13 pointer row now cover the managed-settings case. I checked both against the MS-13 quote in mechanics-sources.tsv, which reads "loads only the managed policy files, or none at all when the definition comes from managed settings". The new wording matches the quote. The added recheck trigger ("changes what an omitClaudeMd agent keeps") covers the clause that was added.
  • plugins/instruction-placement/skills/migrate/reference/verification.md: the new paragraph gives the skill's own reason for using --model sonnet (the probe tests the loader, not the model). It does not restate upstream behavior. It points at the anchored model-config#model-aliases section, with an as-of date and a recheck trigger, so it meets .claude/rules/skill-bodies-state-current-rules.md. It makes no cost claim, so .claude/rules/cost-claims.md is not engaged.
  • .changes/instruction-placement/…-c3f60a18.md: a bump: patch fragment in the same shape as the plugin's existing fragment. Patch fits a documentation-accuracy fix.

Not applicable

  • Closing issue: the PR context has no closing-issue section (the PR says Refs: #6916 and closes nothing), so I checked no acceptance criteria.
  • Plugin manifests: no plugin.json or marketplace.json changed.

Author-claimed and unverified

  • The PR body says scripts/check-affected.sh --tests gave 14 passed and 2 skipped. I did not run it because this lane has no shell.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

The pr-verify verifier failed head 15ab9d3ae90c67e0aa583cc5d8f6d3afc9023f2c. What it wrote, as data:

What it wrote (23 lines)
Summary: PR #11786 delivers only part of #6916 (it says `Refs: #6916`). The issue asks for the full
  `/multi-agent:audit-defaults repo` sweep, with each confirmed finding fixed or filed. The body
  names its part: two wave-5 drift findings in `instruction-placement`. The edits are
  documentation-only, stay within the issue's scope and hold together. Every suite that covers the
  change passed. But the body never says what remains of #6916 for later work, which a partial
  delivery has to do, so the verdict is fail.
- PR body: names no remaining work for #6916. A partial delivery must state what is left. To fix,
  add a `Remaining` section, for example: the files not yet swept (unsent and capped), the confirmed
  findings from earlier waves that are still unfixed or unshipped, filing the issue cuts, and
  posting the final count comment. Also say this PR does not close #6916.
- PR body: the two wave-5 (wave G) findings are not in any trusted spec comment on #6916, which
  records waves up to wave 4. List the findings with their file:line and upstream basis in the body,
  or link the host-run comment that records them, so a reviewer can trace each edit to a confirmed
  finding.
- plugins/instruction-placement/context/verified-mechanics.md:37: the surface-table cell and the
  MS-13 row now cover the managed-settings `omitClaudeMd` case, and the recheck trigger was widened.
  The PR says the MS-13 quote in `mechanics-sources.tsv` already covers this. That file is not in
  the diff, so this could not be checked.
- plugins/instruction-placement/skills/migrate/reference/verification.md:77: adds a reason for
  `--model sonnet`, labeled as this skill's own choice, and a model-config#model-aliases pointer
  with an as-of date and recheck trigger. It does not change behavior.
- upstream-jobs.json: check-plugins, check-skills, lint-repo and test-bash passed. test-python and
  test-node were skipped, which is expected for a markdown-only change.

This pull request leaves the merge queue, and ci-status holds it out while it carries pr-verify-failed. A pr-verify pass at a new commit removes the label.

@github-actions github-actions Bot removed the pr-verify-failed pr-verify failed this head; a pass at a new commit, or after a trusted body edit, removes it. label Nov 1, 2026
@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 1, 2026
Merged via the queue into main with commit 408a7cc Nov 1, 2026
40 checks passed
@kyle-sexton
kyle-sexton deleted the docs/6916-w5-instruction-placement-pointers branch November 1, 2026 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant