Skip to content

docs(implementation): qualify model and effort pin claims - #11573

Merged
kyle-sexton merged 4 commits into
mainfrom
docs/6916-implementation-pointers
Oct 31, 2026
Merged

kyle-sexton merged 4 commits into
mainfrom
docs/6916-implementation-pointers

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Refs: #6916

Summary

Delivers the plugins/implementation part of the repo-mode /multi-agent:audit-defaults sweep. The text said a frontmatter model or effort pin always holds; upstream ranks other sources above it.

Fix

  • implement-dispatch no longer says a dispatch lands on the intended tier "regardless": it states this repository's decision and leaves how the binding resolves to two sub-agents sections.
  • scoped-implementer no longer says the phase "never" runs at the session's level, and its record covers every source ranked over the pin.
  • implementer adds a model-config#model-aliases pointer to its model-binding record.

The pilot's fourth finding here, a dead anchor at scoped-implementer.md:157, was refuted: the raw re-check on 2026-10-31 found id="recommended-effort-levels-for-claude-sonnet-5-5" still on the rendered page. The link now uses the section heading anyway, because a raw read cannot find that legacy id.

No routing or dispatch rule changes. These edits add qualifiers and pointers and cut nothing, so no eval evidence applies.

Verification

  • Each claim was read against the raw sub-agents and model-config pages on 2026-10-31.
  • scripts/check-affected.sh --tests: passed on the new head.
  • Left out: claude plugin eval, because this run spawns none and no edit is a cut.

Related

Remaining

🤖 Generated with Claude Code

kyle-sexton and others added 2 commits October 31, 2026 10:39
The dispatch and agent text said a frontmatter pin always decides the
tier. Upstream lists sources ranked above it, so point at those
sections with an as-of date and recheck trigger.

Refs: #6916

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review October 31, 2026 15:29
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T15:31:02.860868Z c5e142d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 3950a8c6ce87b23b84b2281b66000b91c94354a0: 0 finding(s), 0 as inline comments.

No security findings.

The diff is four prose-only files: a changelog fragment and the bodies of implementer.md, scoped-implementer.md and implement-dispatch/SKILL.md. I read all of it. No .claude-plugin manifest changed, so there are no manifest <field> lines.

Instruction-surface check. Two edits soften wording, so I read them as possible rule removals.

  • implement-dispatch/SKILL.md:77: "lands on the intended tier regardless of the orchestrator's model" becomes "needs no per-call model", plus pointers to the upstream sub-agents sections. The routing rules around it are unchanged. That covers the sonnet provider check, the printenv read, the explicit per-invocation model: sonnet, and the frontier and security-surface routing to implementer.
  • scoped-implementer.md:145: "never runs at the session's level" becomes "does not follow the session's level". The rule that a dispatcher passes no effort is unchanged, as are the STOP-and-escalate clause and the downward-routing restriction.

Neither edit removes a control. Both correct an overclaim by saying the frontmatter pin can be outranked upstream. Nothing was removed that a hook, permission rule or validator would otherwise have to enforce. I did not consult docs/conventions/instruction-exception-register/README.md. Nothing in the diff removes a rule, so no protected class was in play.

Other changes. The scoped-implementer.md effort-levels pointer now uses the section heading #recommended-effort-levels instead of the legacy anchor. The As of dates moved to 2026-10-31. The changelog fragment is a bump: patch entry. None of these touches code, secrets, tokens, workflows, or any trusted-actor, kill-switch or merge-hold file. The PR text has no embedded instructions.

Spend. Nothing in the diff adds runs, turns, models or schedules, so there is no spend to report.

critical-findings: 0

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

claude-review reviewed 3950a8c6ce87b23b84b2281b66000b91c94354a0: 0 finding(s), 0 as inline comments.

No findings. The PR changes documentation only: it qualifies the "pin always holds" wording in implement-dispatch, scoped-implementer and implementer, and adds a changelog fragment (bump: patch).

  • The diff touches no routing or dispatch rule, so a patch bump fits. I found no userConfig or manifest change, so no manifest <field> lines apply.
  • The old "regardless of the orchestrator's model" and "never runs at the session's level" wording is gone from plugins/implementation; I grepped for both phrases.
  • The only recommended-effort-levels reference left is the new heading-based link at scoped-implementer.md:157.
  • The "As of 2026-10-31" dates match the PR's stated re-check. I did not re-read the upstream pages myself, so the claims about what ranks over a pin are author-claimed and unverified.
  • The closing-issue criteria are not testable here: the PR only references docs(multi-agent,session-flow): fix repo-mode audit pilot findings and schedule a full sweep #6916 (Refs), so no issue section is in the context file and no criteria apply.
  • Trusted paths: none of the four changed files matches a listed glob.
  • Cost: no billing or paid-plan change. There is no spend to note.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c5e142d901

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions

Copy link
Copy Markdown
Contributor

The pr-verify verifier failed head c5e142d901d3eecca8f5b8432ea42d36ce548b59. What it wrote, as data:

What it wrote (23 lines)
Summary: The PR refs #6916 and delivers the plugins/implementation part of the audit-defaults sweep.
  The sweep's pilot comment on #6916 confirmed four findings in this plugin, and the diff handles
  three of them. It qualifies "regardless" in implement-dispatch, rewords "never" in
  scoped-implementer and widens its pointer, and adds the model-aliases pointer to implementer. The
  fourth finding, a dead anchor `#recommended-effort-levels-for-claude-sonnet-5-5` in
  scoped-implementer.md, is left unchanged. The PR body neither fixes it, nor reports a re-check
  that dropped it, nor lists it under Remaining. The plugin's part is therefore not delivered whole.
- plugins/implementation/agents/scoped-implementer.md:157: the pilot finding at
  scoped-implementer.md:149 calls
  `https://platform.claude.com/docs/en/build-with-claude/effort#recommended-effort-levels-for-claude-sonnet-5-5`
  a dead anchor and says to re-point it to `effort#recommended-effort-levels`. The diff leaves that
  link unchanged. Either re-point it, or say in the PR body that the raw re-check on 2026-10-31
  found the anchor live and the finding dropped. Without either, the finding is not fixed and not
  listed as remaining work.
- plugins/implementation/skills/implement-dispatch/SKILL.md:112: the finding asked to list the cases
  that move a subagent off the tier (env force, mod `agent.spawn`, `availableModels`, non-Anthropic
  provider). The diff points at the two sub-agents sections instead of listing them. That is
  acceptable as pointer hygiene, so it is not blocking, but a human may prefer the cases named
  inline.
- PR body: the Remaining section names the rest of the sweep and the ci-status check but not the
  scoped-implementer anchor finding. Update it if that fix is deferred.
- The diff only edits docs and agent instructions. It does not touch secrets, settings, the takeover
  set or routing logic, and no prompt-injection text was found.

This pull request leaves the merge queue, and ci-status holds it out while it carries pr-verify-failed. A pr-verify pass at a new commit removes the label.

@github-actions github-actions Bot added the pr-verify-failed pr-verify failed this head; a pass at a new commit, or after a trusted body edit, removes it. label Oct 31, 2026
kyle-sexton and others added 2 commits October 31, 2026 12:37
The dispatch line paraphrased how the harness ranks the binding, so
state only this repository's decision and leave the rest to the
pointer. Point the effort record at the section heading a raw read can
find.

Refs: #6916

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot removed the pr-verify-failed pr-verify failed this head; a pass at a new commit, or after a trusted body edit, removes it. label Oct 31, 2026
@kyle-sexton
kyle-sexton added this pull request to the merge queue Oct 31, 2026
Merged via the queue into main with commit 0b0b957 Oct 31, 2026
42 checks passed
@kyle-sexton
kyle-sexton deleted the docs/6916-implementation-pointers branch October 31, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant