Repository navigation
refactor(planning): one owner for the authoring-formats resolution ladder - #11168
Conversation
…dder The acceptance_criteria_format ladder was restated in interview's context/ears.md and in prd, and the same ladder for diagram_dialect in design. It now lives once in context/authoring-formats.md, written with <plugin-root> and <project-root> placeholders that each reading skill's body fills; each skill keeps only its key's default, degrade target and provenance label. Adds eval cases for the ears and dbml convention paths, and repins the ears.md digest: context/ears.md is unchanged: d44ad1a0d4b3ceba53b4f962afd8afee2d939dc5b68c305a0318dd18a31ecc54 -> 903332451df15c686d46259080f54f82824287b1efe4199a42716e5e95609c6f Only the ladder moved out; the EARS tag vocabulary and bullet shapes are unchanged. Refs: #10119 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed No security findings in the incremental change (since 6903a0f). All 12 changed files are eval fixtures, sample data and one changelog line under
manifest: no manifest touched. |
|
claude-review reviewed No findings in the incremental review (changes since 6903a0f). I hand-traced each regex and the sample files, and ran none of them, so these checks are by reading only.
Cost: the new |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6903a0f2ca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…e in the convention cases criteria-tagged now fails when any AC bullet in the Brief's acceptance criteria section is untagged, not only when none is tagged; a mixed tagged/untagged sample is added as a fail. dbml-artifact now requires scope: data and dialect: dbml inside the frontmatter, with wrong-scope and body-only samples as fails. Refs: #10119 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
prd-ears-convention-tags-criteria runs /planning:prd in a repository whose convention home selects acceptance_criteria_format: ears and checks that every acceptance criterion the PRD records carries an exact EARS tag, so prd's pointer to the shared resolution ladder is covered by an outcome. Refs: #10119 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closes #10119
Refs: #6917
Summary
/planning:interview(incontext/ears.md, since #11074) and/planning:prdeach restated theacceptance_criteria_formatresolution ladder, and/planning:designrestated the same ladder fordiagram_dialect. The ladder now lives once, inplugins/planning/context/authoring-formats.md. Each skill points at that file and keeps only what is specific to its key: the default, what a degrade emits, and design'sunset (no C4 view emitted)provenance label.Fix
plugins/planning/context/authoring-formats.md: the ladder steps, the resolver's exit codes, the untrusted-input rule, and why the ladder sits in the plugin rather than in a citation of the publisher's docs. It arrives through Read unsubstituted, so it writes<plugin-root>and<project-root>, and each reading skill's body supplies both values.context/ears.md, prd and design: each ladder block is replaced with a pointer plus its key-specific lines.docs/contracts/authoring-formats(1.0.4, clarification): a consuming plugin restates the ladder once, in a file it bundles, instead of once per skill. The config-cascade row now says the same.context/ears.md is unchangedpin is repinned withtests/repin.sh. Only the ladder moved out of ears.md; the EARS tag vocabulary and bullet shapes are unchanged.interview-ears-convention-tags-criteria:earsproduces taggedAC<n>: [<pattern>]criteria in the Brief.design-dbml-data-dialect:dbmlproduces anentity-relationships.mdlabeleddialect: dbmlwith adbmlfence.Verification
git grep -n -i 'acceptance_criteria_format' -- plugins/: the steps appear only incontext/authoring-formats.md. The skills, README and CHANGELOG mention the key without restating them.bash plugins/planning/tests/interview-defenses.test.sh: PASS after the repin.scripts/check-affected.sh --testson the committed head: 14 passed, 2 skipped.validate-cases.py plugins/planning/evals: no FAIL.Before and after evals
Setup:
claude-opus-5-5in every trace, judgeopus.origin/main; after is this branch. Both copies sit outside the repository and run the same case set.claude plugin eval <copy>/plugins/planning --ablation none --scaffold --trust-plugin --keep-temp --allow-tools Bash Write Edit --judge-model opus --threshold 0.8 --runs 3 --no-publish.--ablation noneruns the with-plugin arm only, so each comparison is before versus after, not with versus without.Mean case score over 3 runs:
interview-ears-convention-tags-criteria(new)interview-consumer-standard-overrideinterview-lock-restates-probleminterview-prd-seeds-briefprd-handoff-scope-clearprd-next-unsure-midflowdesign-dbml-data-dialect(new)design-brief-nfr-not-reaskeddesign-fact-placed-oncedesign-one-way-door-adr-promptdesign-prototype-reversibility-deferredrun-validity.py --runs 3printsverdict: VALIDon all four result files: two passes, before and after each. The only warning isskill fired, which is expected because each prompt starts with the slash command.noise-report.py after --baseline before --margin 0.05: change +0.01, 95% interval -0.01 to +0.03,non-inferior at margin 0.05.not shown non-inferior at margin 0.05. With 4 cases the interval is wider than the margin. No case's score went down.resolve-convention-home.shin 3 of 3 runs and pass 3 of 3. Moving the ladder into the context file did not lose theearsordbmlpath.design-one-way-door-adr-promptfails itsone-way-with-adrgrader in every run of both versions, so this change did not cause it.context/ears.md. After rebasing onto refactor(planning): move the interview EARS ladder and coverage-prompt exemption into one context file each #11074 and switching the shared file to placeholders, the two convention cases were rerun on the final head: 3 of 3 each, every run readcontext/authoring-formats.mdand called the resolver,run-validity.pyverdict: VALID. The other cases' text did not change in the rebase.Related
🤖 Generated with Claude Code