Repository navigation
fix(intake-triage): say why a size split declines, and split by target subset - #11163
Conversation
…lane The loop-lane README moved to docs/contracts/loop-lane; three comments in admit.mjs and admit.test.mjs still named the old path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
splitChildBody, its pr-verify and issue-lane callers, and the babysit merge gate's mirror now accept one last `Scope:` line on a size-split sub-issue when every target it names is verbatim text of a trusted parent task line. The split record carries a target-subset split's groups for resume. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A Size Large issue whose split was declined stayed parked with the reason only in a step summary. Now: - Every lasting decline (author not a listed human, fewer than 2 trusted lines after refinement, no split found, an invalid partition or target split, an Issue Type admission refuses) posts one fixed-text lanes App comment, marked per reason and body version, with no hold label. refine-select hands a select-time decline to apply-refinement as mode size-decline, so no new token or permission is needed. - An issue with fewer than 2 trusted task lines gets the thin refinement first (owner Q78), and the split runs on the refined lines. - When lines cannot be grouped into whole changes, the model may return groups of target names copied from the lines; each sub-issue holds every line plus one Scope line, which splitChildBody trusts. - admission-rules.json size-split holds on-decline (subset or park) and max-parts, replacing the MAX_PARTS constant and the schema's hard limits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d-size Admission takes a trusted size-split sub-issue whatever its Size (owner Q93), but the issue lane skipped one rated Large as split-required, so it sat held for good. models.issue-dimensions.split-child-size (medium) now gives such a child that size's budget, pinned as that size; any other Large issue still skips with split-required. resolve-config reads the splitChild fact through admit.mjs trustedSplitChild, which applies splitChildBody against the issue's native parent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…its targets A target-subset sub-issue said its done-when was copied as written while it also held the script's Scope line. Its header now says the lines are copied from the parent and the Scope line names this part's targets, and splitChildBody (with the merge gate's mirror) requires that header with a Scope line and refuses it without one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… and split-child-size Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… or that leave a line uncovered subsetProblem now requires every task-list line to hold one of the targets, and the groups to come back from renderSplitRecord through splitRecord, so the record's groups cap and its parser stay one source and an oversized split never leaves an unreadable record behind. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… admit.mjs does scope_target now measures UTF-16 code units and strips only what JavaScript trim strips; two shared vectors pin the agreement. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er line splitRecord reads a record only under SIZE_SPLIT_MARKER, so subsetProblem renders the marker before parsing back the groups. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… line's targets admit.mjs splitScope is the one parser of a trusted split child's Scope line. write-issue.mjs puts its targets in issue.json as `scope` and resolve-pr.mjs in the child's spec entry; the work skill and the pr-verify prompt read each done-when item as applying only to those targets. Only a body splitChildBody trusts is parsed, so with no readable Scope line every item applies in full. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…pe field Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…SPACE JS_TRIM held the same characters as JS_SPACE, so scope_target now uses JS_SPACE and the duplicate constant is gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t.mjs does scope_target encoded the target as strict UTF-16, which raises on a lone surrogate that a JavaScript string can hold; surrogatepass counts it as one code unit, as scopeTarget does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…r sign A target copied from a line such as "Email @contoso about #1234" could be "@contoso" or "#12", which writes a new mention or issue link into the App-filed child body. scopeTarget and the Python scope_target now ban both characters, with a shared vector for each. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rker A target such as "- [ ]" is a substring of every task line, so it passed scopeTarget and alone covered every line. scopeTarget, the split's coverage check and the Python scope_target now match against each line's text after its indent and task-list marker (taskText), with a shared vector for the marker as a target. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
subsetProblem deduplicated only identical targets, so "alpha" and "alpha-tools" passed as two groups and both children owned the alpha-tools work. It now refuses any target that is text inside another target. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…very line per group The resume path checked a record with groups only through subsetProblem, never that its parts are every line once per group. An edited record (parts 1;1) orphaned lines, and parts longer than the groups threw a TypeError at record.groups[index] on every rerun. Such a record now takes the existing "no longer matches" skip. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…enforces Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…admit.mjs resolve-config.mjs is a hold-floor module; importing intake's admit.mjs pulled its whole import closure into the floor and broke the merge-holds sync test. work-resolve-issue's admit job (check-blockers.mjs, which already loads admit.mjs) now reads trustedSplitChild and hands it to the dimensions resolve as the split-child input. resolve-config refuses any value but true or false when it reads the issue's dimensions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…lve too run-checks resolves with no activity, so it reads the unpinned issue dimensions and needs the fact resolve-config now takes only from its caller; without it every issue run failed run-checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed No security findings in this change. critical-findings: 0 I read the whole diff (32 files). The PR context was treated as data. It holds no embedded instructions. Trust controls and trusted paths
Manifests and instruction surfaces
Spend: more issue-lane runs for trusted Large children (at Residual notes, not findings:
|
|
claude-review reviewed No blocking or advisory findings in this review of #11163. I read the whole diff apart from the new test vectors in What I checked
Trusted paths: the changed trusted-path files are
Spend: more lane runs. Trusted Large split children now run instead of skipping as Minor note, not a finding: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cdae9660f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No related issue: owner decision Q93 follow-up; 19 Large issues parked silently
Summary
A Size Large issue whose split was declined stayed parked at
status: ready, and the reason was written only to a workflow step summary. 19 of 25 open Large issues were in that state. A trusted split sub-issue rated Large was admitted, but the issue lane then held it assplit-required.This change:
Fix
Visible decline: each lasting decline posts one fixed-text lanes App comment that names the reason, and adds no hold label. A marker per reason and body version keeps a re-run from posting it again. The reason codes:
not-human: a listed human did not file the issue.few-lines: fewer than 2 trusted task-list lines, even after refinement.no-split,bad-split,bad-subset: no valid split by line or by target.no-type: an Issue Type that admission does not take.A decline found at select time reaches
apply-refinementas modesize-decline. No model runs, and no token scope or permission changes.Refinement first: an issue with fewer than 2 trusted task lines gets the existing thin refinement first (owner Q78). The split then runs on the refined lines at the next triage.
Target-subset split: when the lines cannot be grouped into whole changes, the model may return
groupsof target names copied verbatim from the trusted lines. Each sub-issue then holds every line plus one lastScope:line. Its header says that the lines are copied from the parent and that the Scope line names this part's targets.splitChildBodyaccepts the Scope line only under that header, and only when every target in it is verbatim parent text.splitChildBody, so they apply the same rule.subsetProblemrefuses groups that the split record cannot hold (it round-trips them throughrenderSplitRecordandsplitRecord). It also refuses a target that sits inside another target, a target holding@or#, and groups that leave a task line without a target. Targets are matched against the line text after its checkbox.Scope narrows the criteria:
splitScope(admit.mjs) reads an accepted child's Scope line. The issue lane passes it asscopeinissue.json, and pr-verify passes it in the child's spec entry. The work skill and the pr-verify prompt apply each criterion only to those targets. With noscope, every criterion applies.Configuration:
admission-rules.jsongainssize-split:on-decline:subsetorpark, defaultsubset.max-parts: 10.This replaces the
MAX_PARTSconstant and the hard-coded item limits in the schema.Split child rated Large:
pr-pipeline.yamlgainsmodels.issue-dimensions.split-child-size: medium.splitChildfact throughadmit.mjstrustedSplitChild, which appliessplitChildBodyagainst the native parent. The fact is read only while the dimensions are not yet pinned.split-required.checkDimensionsrefuse asplit-child-sizethat names no size that runs.Docs: the pr-pipeline README (Models) and
pr-run-activity.mddescribe declines, target-subset splits,size-splitandsplit-child-size. Changelog fragments were added for pr-pipeline and source-control.Verification
node --testover.github/scripts/intake-triage,.github/scripts/pr-verify,.github/scripts/work-resolve-issueand.github/actions/resolve-config(*.test.mjsin each): all pass. Each new test failed before its change.admit.test.mjs,resolve-pr.test.mjsand the babysittest_babysit_split_child_trust.pyall read them. Each suite failed before the fix and passes after it.actionlint .github/workflows/intake-triage.yml: clean.python3 -I scripts/sync-hold-floor.py --check: clean.scripts/check-changelog-fragments.sh --check: all fragments valid.scripts/check-affected.sh: 14 passed, 1 skipped.Related
🤖 Generated with Claude Code