Skip to content

docs(evals): record the 2.1.312 recheck of the worktree eval guard - #11100

Merged
kyle-sexton merged 3 commits into
mainfrom
host-run/5696-plugin-eval-guard-recheck
Oct 30, 2026
Merged

kyle-sexton merged 3 commits into
mainfrom
host-run/5696-plugin-eval-guard-recheck

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Refs: #5696

Summary

Problem: in a worktree-isolated session the Bash guard refuses claude plugin eval, reading the subcommand as shell eval. The issue asks for a recheck on each release and closure once it passes. On Claude Code 2.1.312 it still fails in a --worktree session, so this PR records the recheck and leaves the issue open.

Fix

  • plugins/evals/skills/plugin-eval/SKILL.md: the worktree guard row in Sources now cites 2.1.312, checked 2026-10-29.
  • reference/records.md, Worktrees: a recheck line with the result per session shape. A claude -p --worktree session still refuses claude plugin eval --help with the same message, and a normal session started in a git worktree add worktree runs it.
  • A patch changelog fragment for evals.

Verification

  • Probe on Claude Code 2.1.312 (subscription login, --permission-mode auto), with an echo ok control in each shape: --worktree session refused, normal session in a worktree allowed.
  • scripts/check-affected.sh --tests: 14 passed, 2 skipped.
  • Left out: nothing.

Related

🤖 Generated with Claude Code

@kyle-sexton
kyle-sexton marked this pull request as ready for review October 30, 2026 01:04
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T01:06:03.544990Z e4621f6 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 2b1bc68f361637f0eebf07d63252c46ccb8a5871: 0 finding(s), 0 as inline comments.

No security issues found in the incremental change (e4621f6 → 2b1bc68).

The only file that changed is plugins/evals/skills/plugin-eval/reference/records.md. It moves one "Recheck: re-run claude plugin eval --help in a --worktree session and in a normal session started in a worktree." line up from under the 2026-10-29 recheck record to sit under the earlier session-shapes record it belongs to. No wording changed. The diff deletes, narrows or softens no instruction, and it touches no manifest, trust control, token scope, kill switch or merge hold. This file is a verification record read by people, not a standing instruction to the model, so the instruction-surface lens finds nothing removed.

Skip gate 2 applies: the change has no security-relevant surface. I did not read the PR context file or the full diff, because the incremental diff is self-contained and the rest of the PR was reviewed at the earlier SHA.

No manifest fields were hit, so there are no manifest <field> lines.

critical-findings: 0

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

claude-review: 1 inline finding(s) on e4621f607a4370922dcacdda87f8c9441b112ca7; the summary is in this lane's pull request comment.

claude-lane: claude-review

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

claude-review reviewed 2b1bc68f361637f0eebf07d63252c46ccb8a5871: 0 finding(s), 0 as inline comments.

Incremental review of plugins/evals/skills/plugin-eval/reference/records.md: no findings. The change moves the Recheck: instruction from under the 2.1.312 recheck bullet to the end of the "Session shapes" bullet, where the instruction belongs because it describes how to re-run those probes. It is a docs-only edit. The 2.1.312 record now reads as a complete, self-contained line, and the other bullets keep their own recheck instructions. No security, trusted-path, cost or prepaid-spend implications.

…record

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit a731bbb Oct 30, 2026
40 checks passed
@kyle-sexton
kyle-sexton deleted the host-run/5696-plugin-eval-guard-recheck branch October 30, 2026 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant