Repository navigation
feat(pr-pipeline): hold for a person only on the owner's three reasons - #10954
Conversation
…er's three reasons escalation-routes.json now routes `hold` (needs-human) only for an intent or design question, a person's own thread or hold, and a HIGH or CRITICAL security risk. Protected-path stops, ci-fix-weaken-required after its fresh fixer round, and the review-dependency stops other than security-close, escalate and fix-refused route `fail` with "label": "needs-session", which report-escalation.sh adds before its lane-stopped comment. A well-formed reason the table does not list now holds for a person. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQb9Q3ucKDVyHvpcU5cfU8
…item contract The adjudicate-feedback job stages the linked issues' trusted spec text, read by pr-verify's resolve-pr.mjs linkedIssues (now exported), as contract.json. A lane or reviewer verdict on an intent or design question must quote it: the script keeps the quote only as an exact substring of the staged text, at least 20 characters, and the reply quotes it with the issue's URL. Otherwise the question stays a person's hold. A security question, a CRITICAL finding and a security-review IMPORTANT finding never settle by quote. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQb9Q3ucKDVyHvpcU5cfU8
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review of PR #10954 (head bf75b33): no findings. critical-findings: 0 What I read: the whole diff (32 files) and the PR context. Bash was unavailable, so I read changed files with Read and Grep only. I did not consult Route changes (
Adjudicator quote path (
Workflow token (
Hold floor. Removed holds, not findings. The path, protected-path and pin or repin holds listed above become failing statuses plus a label, so they fall under the owner's named friction holds. I hold nothing for them. Spend. One extra adjudicator input file per disputed thread. It uses prepaid or subscription usage only and starts no billable resource. Manifest fields: no |
|
claude-review reviewed No blocking or advisory findings on head bf75b33. I did not run any tests: this lane has no shell. The 978/178/645/200 test counts in the PR description are the author's and unverified by me. What I read
Checks that held
Observations, not findings
Closing issues: the PR uses Manifests: no Spend: no billed resource or paid plan changes. The adjudicator model calls it already ran now also read |
…-reason-holds # Conflicts: # .github/scripts/pr-verify/resolve-pr.mjs
A ci-fix-escalated stop routed fail with no label, so once its same-head retry was spent no queue held the pull request. It now names "label": "needs-session", as ci-fix-weaken-required does, and report-escalation.test.sh covers it among the session reasons; the fail-comment cases move to ci-fix-round-cap, still unlabeled. Refs: #10971 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQb9Q3ucKDVyHvpcU5cfU8
…-reason-holds # Conflicts: # docs/conventions/loop-lane/README.md
…uote dismissals for a person - review-dependency and apply-dependency-patch list needs-session in labels-absent, so a dependency stop routed to the session builder gets no same-head model re-run and no fresh round budget on a rebased head until a session removes the label. - A quoted contract line only keeps a finding standing: a lane verdict on an intent or design question goes to a person, since the quote proves the text exists, not that it bears on the finding. The prompt and the lane reply drop the lane-side quote. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQb9Q3ucKDVyHvpcU5cfU8
…the needs-session queue Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQb9Q3ucKDVyHvpcU5cfU8
… as a file in it
admit.mjs reads `new URL("../../workflows/")`, and import_closure crashed
with IsADirectoryError on it. Follow loaded_closure's convention: a module
that reads a whole directory stands for a file in it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VQb9Q3ucKDVyHvpcU5cfU8
… fix Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQb9Q3ucKDVyHvpcU5cfU8
…losure admit.mjs reads `../../workflows/` only for the workflow names; it loads no code from there, and every gated workflow is floored by name. Standing for `.github/workflows/any.yml` (loaded_closure's convention) fits only an assertion that also accepts CARRY_REFUSES; this one checks the floor alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ked spec through adjudicate-feedback.mjs now loads resolve-pr.mjs and admit.mjs to stage the linked issues' spec text a quote settles a question from, so their closure decides a stop route. Floor the seven files as enforcement, as request-budget.mjs is for the same reason, and regenerate the copies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The pr-unblock lane stopped
When a retry on this head can change the outcome, the lane runs one on its own, up to its per-head cap, and edits this comment if it stops again; a run that does not stop clears the status. When no retry can (a review thread the lane does not take or settle, or a failing check after the retries are spent), a person resolves the threads or gets the checks green, then dispatches the workflow below: that run finds the cause gone and clears the status. On a pull request the lanes App opened, the dispatchers start that run once per stop; on any other, a person does. A new commit to the branch starts clean. To run it again on this head now, dispatch the gh workflow run pr-unblock.yml -R melodic-software/claude-code-plugins -f pr-number=10954 -f activity=resolve-conflicts |
Lane-Activity: pr-unblock/resolve-conflicts
…tions path The contracts move left the relative link one level short, which failed lint-repo's offline link check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The pr-unblock lane stopped on this pull request and needs a person: a conflicted path is a workflow, submodule config or a settings file, which the lane does not resolve.
To resume, deal with the reason above, remove the gh workflow run pr-unblock.yml -R melodic-software/claude-code-plugins -f pr-number=10954 -f activity=resolve-conflicts |
A tests-only verdict carrying a design or intent question and a quote was kept and then acted on from green CI. Reject it as malformed, as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Settling the pr-verify findings from head 40477ab. That run read the old body, which cited "No related issue: owner standing direction". The body now cites #10517 as the trusted source.
|
|
The pr-unblock lane stopped on this pull request and needs a person: a conflicted path is a workflow, submodule config or a settings file, which the lane does not resolve.
To resume, deal with the reason above, remove the gh workflow run pr-unblock.yml -R melodic-software/claude-code-plugins -f pr-number=10954 -f activity=resolve-conflicts |
…-reason-holds # Conflicts: # .github/workflows/pr-require-checks.yml # plugins/source-control/skills/babysit-prs/scripts/tests/test_babysit_risk.py # plugins/source-control/skills/babysit-prs/scripts/tests/test_merge_holds_sync.py
|
The pr-unblock lane stopped on this pull request and needs a person: the pull request changes .github/workflows/, which the lane token cannot push, so the lane does not address its review threads.
To resume, deal with the reason above, remove the gh workflow run pr-unblock.yml -R melodic-software/claude-code-plugins -f pr-number=10954 -f activity=address-feedback |
…-reason-holds Compose both sides in the eight conflicted files: - escalation-routes.json: keep the branch's ci-fix-escalated why; both sides add the needs-session label (#11175). - escalation-routes.mjs, report-escalation.sh header: main's wording plus the branch's three-reason hold and fail-safe for an unlisted reason. - report-escalation.test.sh: the branch's HOLD/SESSION reason sets with main's stricter no-other-label check. - pr-pipeline.yaml: review-dependency and apply-dependency-patch wait on needs-session and "security: outside-actor". - live-config.test.mjs: keep both new tests. - pr-require-checks.yml: the branch's floored paths with main's path-holds guard (sync-hold-floor.py --check clean). - pr-pipeline README: the branch's routing text plus main's note that a session, not a lane, removes needs-session. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs: #10517
Refs: #10971
Authority
#10517 (owner-filed) asks that every needs-human path either route to a lane or be named as a kept trust control, because the owner's stop rule, recorded on main in
docs/contracts/loop-lane/README.md("When work stops for the owner"), allows a person only for three reasons. That section quotes the owner verbatim: "I (the human) should only ever be in the loop or involved via signals like needs-human / needs-decision labels if there is 1. A change in original intent/vision 2. Something comes up during implementation [...] that alters intent/vision or the primary design 3. A real HIGH/CRITICAL security or cost risk", and "Any other stop is a defect to fix, not a reason to ask me." The pr-unblock holds this PR reroutes are such paths. ADR 0074 records the dependency round cap as judgment ("The cap is judgment"), not an owner-kept control; no owner decision on main keeps it with a person.A
needs-sessionroute is still a stop:route: failposts a failingpr-unblock/<activity>status on the head, so the PR cannot merge until the cause is fixed. Only the actor changes, from a person to an agent session. No protected-path, supply-chain or workflow-pin check is removed or weakened; the lane still refuses to push those paths itself.The owner's standing direction (2026-10-29), quoted verbatim, settles the protected-path, supply-chain and round-cap re-routes: "Holds that guard against our own actors (path holds, trust-path holds, person-approval holds, bot-author holds, pin/repin ceremony) are friction, not security boundaries, and come off now."; "Section 3's 'high/critical boundary' means only: a token or secret leaking, my accounts being compromised, or anything that bills me."; "A decision I made in any session binds every session." Every route this PR changes still stops the PR (a failing status) and only changes who answers it. None of them guards a token or secret leak.
Summary
The pr-unblock lanes handed a PR to a person (
hold, human-gated label) for many stops that are not the owner's three reasons. This PR keepsholdonly for an intent or design question, a HIGH or CRITICAL security or cost risk, or a person's own thread or hold, and sends the rest to the session-builder queue.Route table (
.github/scripts/pr-unblock/escalation-routes.json):protected-path-conflictneeds-sessionconflict-patch-protected-pathneeds-sessionfeedback-protected-pathneeds-sessionci-fix-protected-pathneeds-sessionci-fix-weaken-requiredneeds-sessiondependency-round-capneeds-sessiondependency-fix-not-landedneeds-sessiondependency-config-unreadableneeds-sessiondependency-files-truncatedneeds-sessiondependency-control-uncitedneeds-sessiondependency-workflow-unpinnedneeds-sessionci-fix-escalatedneeds-sessionKept as holds, each with its reason:
feedback-round-cap: round cap reached while an open thread is a security finding rated IMPORTANT or above, an intent finding, or a person holds the PR.feedback-uncertain: a CRITICAL finding, a security-review finding rated IMPORTANT or above or unrated, or one no known lane wrote; no adjudicator judges these.feedback-disputed: a disputed finding only a person decides (same classes, or a thread a person directed).feedback-question-intent: the dispute turns on what the change is meant to do.feedback-question-design: the dispute turns on a design choice.feedback-question-security: the dispute turns on a security judgment.dependency-security-close: the review would close a security update.dependency-escalate: the review found a risk the lane does not decide alone.dependency-fix-refused: a non-Dependabot commit changes more than a manifest or lock version, so the lane cannot vouch for it.A reason the table does not list now holds for a person with no activity to resume (fail-safe), where it used to make
report-escalation.shexit with an error.Fix
escalation-routes.jsongives 12 reasonsroute: failwithlabel: needs-session: the 11 holds above andci-fix-escalated, already a fail route, which left a PR with no next actor once its same-head retry was spent (fix(pr-pipeline): give a ci-fix-escalated stop a next actor #10971).report-escalation.shapplies that label (only on a fail route, and only a well-formed label name) before the comment that explains it, and the comment names the queue.adjudicate-feedback.mjs): it reuses pr-verify'slinkedIssues(now exported fromresolve-pr.mjs) to stage the linked issues' spec text asadjudicate/contract.jsonper slot. A verdict that settles a dispute by quote must quote an exact substring of that contract text, at least 20 characters after trimming (QUOTE_MIN), and settles onlyquestion-intentandquestion-design. Security questions, CRITICAL findings and unrated security findings never settle by quote; they still reach a person.babysit_risk.FLOOR_CLASSES, copies regenerated byscripts/sync-hold-floor.py):resolve-pr.mjs,write-verdict.mjs,intake-triage/admit.mjs,select-trusted-text.mjs,lib/publish-gate.mjs,.github/recurring-schedule.jsonandplugins/work-items/scripts/charge-words.jsonjoin asenforcement, because the adjudicator now loads them to read the linked spec a quote settles a question from, so they decide a stop route (asrequest-budget.mjsdoes).pr-unblock.yml,pr-pipeline.yamland theloop-laneandpr-pipelineconvention docs describe the new routes and theneeds-sessionqueue.Verification
node --testrun inside.github/scripts/pr-unblock/(the package's owntestscript) after mergingorigin/main: 978 tests, 978 pass, 0 fail.report-escalation.test.shcovers the fail-plus-label route, the label-before-comment order and the unknown-reason hold.ci-fix-escalatedis in its session reasons, andci-fix-escalated, session: label is needs-sessionpasses. The fail-comment edit-in-place cases now useci-fix-round-cap, which is still unlabeled. The suite reports 0not ok.origin/mainmerge, which resolved theresolve-pr.mjslinkedIssuesconflict by keeping the export and main'swebHostsparameter:node --testpasses in.github/scripts/pr-unblock(978),pr-verify(178) andpr-merge(645), and in.github/actions/resolve-configforcallers.test.mjs(200).scripts/check-changelog-fragments.sh --checkand--check-required origin/mainboth pass.node --test .github/scripts/pr-unblock/from the repository root, which Node v24.21.0 refuses with MODULE_NOT_FOUND (it treats the directory as a module); the same tests ran from inside the directory instead.Related
needs-sessionlabel is declared and deployed (github-iac#794, github-iac#799), so the ordering this PR waited on is met.needs-humanfrom one of the rerouted reasons are swapped toneeds-sessionby hand; new stops getneeds-sessionfromreport-escalation.shdirectly.🤖 Generated with Claude Code
https://claude.ai/code/session_01VQb9Q3ucKDVyHvpcU5cfU8