Repository navigation
fix(evals): fail the validity gate when a case's scaffold_script never ran #10919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
melodic-automation-lanes
wants to merge
9
commits into
main
from
work-resolve-issue/issue-10504-40838028768-1
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b559753
Resolve issue #10504
melodic-automation-lanes[bot] 15f7f7d
Fix failing CI checks on work-resolve-issue/issue-10504-40838028768-1
melodic-automation-lanes[bot] 13dab33
Address review feedback on work-resolve-issue/issue-10504-40838028768-1
melodic-automation-lanes[bot] 8be3dcc
Fix failing CI checks on work-resolve-issue/issue-10504-40838028768-1
melodic-automation-lanes[bot] edc3718
Address review feedback on work-resolve-issue/issue-10504-40838028768-1
melodic-automation-lanes[bot] 5a45528
Fix failing CI checks on work-resolve-issue/issue-10504-40838028768-1
melodic-automation-lanes[bot] 360d8de
fix(evals): name the scaffold check in SKILL.md and read a BOM or nex…
kyle-sexton 36dc479
docs(evals): scope the scaffold check's unchecked case to runs withou…
kyle-sexton e1398f2
Merge main into work-resolve-issue/issue-10504-40838028768-1
melodic-automation-lanes[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| bump: patch | ||
| --- | ||
|
|
||
| ### Fixed | ||
|
|
||
| - **plugin-eval:** the validity gate's new `scaffold` check marks a run INVALID when a case's `case.yaml` sets `context.scaffold_script` and the gate was not given `--scaffolded`. Without `--scaffold` the eval skips such a case's script, both arms run in an empty workspace, and the gate had still printed `verdict: VALID`. Pass `--scaffolded` when the eval ran with `--scaffold`, since no documented result field records it. A `case.yaml` or case directory the gate cannot read, or a result with no suite root or case directory to find it by, leaves the check unchecked. A `case.yaml` that starts with a UTF-8 byte order mark, or puts the `scaffold_script` value on the next line, still counts as setting a script. ([#10504](https://github.com/melodic-software/claude-code-plugins/issues/10504)) |
|
melodic-automation-lanes[bot] marked this conversation as resolved.
Resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
melodic-automation-lanes[bot] marked this conversation as resolved.
Resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.