Repository navigation
fix(pr-pipeline): route workflow-staged to a failing status, not needs-human - #10790
Conversation
…s-human A resolve-conflicts stop on workflow-staged now ends in a failing pr-unblock/conflict status and the lane-stopped comment instead of needs-human. The merge carries the pull request's own .github/workflows/ changes together with the base's, which the lane token cannot push, and nothing in it is a person's decision, so a session merges main by hand. escalation-routes.json routes it fail, and the stopping check skips lane-stopped. clear-escalations.mjs still lifts a workflow-staged label an older lane run set, on the same evidence as before. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…licts push stops The push-job rows for unresolved-conflict and unexpected-path-staged named the awaiting-human skip, but both reasons route fail, so the stopping check skips lane-stopped. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-review reviewed No findings. I read the diff and PR context and checked the other places that mention
|
|
claude-security-review reviewed No security findings in this PR. critical-findings: 0 What changed. Merge hold. The change touches a merge-hold path, so I read what it gates. The stop used to label the PR
Legacy labels. Trust controls. I found no widening of who is trusted, of token scope, of the kill switch, or of untrusted text reaching a lane. The Instruction surfaces and manifests. No standing instruction was deleted or softened, and no plugin manifest was touched, so there are no Spend. No change to paid plans, billing or lane-run frequency. PR context. The description contains no embedded instructions aimed at the review lane. |
Post-merge mutation testingKilled 7, survived 0, timeout 0, no coverage 0, invalid 0, not run 0.
The run's summary has the full report. |
No related issue: lane routing defect seen on #10767
Summary
pr-unblock put
needs-humanon #10767 with reasonworkflow-staged. The lane refuses to push a base merge whose.github/workflows/tree is not exactly the base's (apply-patch.mjsworkflowsAreBaseOwn). On #10767 the PR's own diff changesintake-triage.ymlandwork-resolve-issue.yml, and main broughtpost-merge-test-mutation.yml, so the refusal itself was correct. The route was not: a merge the lane token cannot push is a capability limit, and nothing in it needs a person's decision. A session merges main by hand.A merge that brings only the base's workflows already pushes. That path and its test (
apply-patch.test.mjs, "a base-side workflow change is admitted only when the merged workflows are exactly the base's") are unchanged.Fix
escalation-routes.json:workflow-stagedroutesfail. The stop now ends in a failingpr-unblock/conflictstatus and the lane-stopped comment, with no label. The stopping check skipslane-stopped(stopSkip). The newwhysays the merge stages the PR's own workflow changes together with the base's, which the lane token cannot push, so a session merges main by hand.clear-escalations.mjs: keeps theworkflow-stagedlift for a label an older lane run set, on the same evidence as before. The test file uses this reason as its main fixture, and no open PR carries the label today.protected-path-conflictstayshold. Resolving a conflict in a workflow, settings or.gitmodulesfile means choosing the content of a security control, and that choice is the owner's.pr-pipeline/README.md(route description, clear table) andpr-run-activity.md(the push row now skipslane-stopped). Changelog fragment for pr-pipeline.Verification
report-escalation.test.shfailed against the route change before the test update (not ok - the routing table holds these for a person, andworkflow-staged: writes the label then a comment). After the update,workflow-stagedruns the fail-route assertions: one comment, no label, failing status. 797 ok, exit 0.node --testover.github/actions/resolve-config/,.github/scripts/pr-unblock/,.github/scripts/pr-merge/and.github/scripts/apply-patch/: 2453 pass, 0 fail.jq emptyare clean on the changed files.Related
update-branchwhen the base brings workflow changes and the App lacksworkflowspermission, and GitHub Support calls this intended (chdsbd/kodiak#853). No token scope is added here.🤖 Generated with Claude Code