Repository navigation
perf(reconcile): read pass artifacts only for heads whose spec moved - #10527
Conversation
The lost-run reconciler read four pass artifacts and each pass's run for every passed PR on every tick, before the one GraphQL pre-filter dropped almost all of them. Run the pre-filter first against the head's earliest checks run, which every pass at the head started after, so it drops only heads the old path also dropped; the pass reads and the existing pre-filter then run for the heads it keeps. ci-status now also writes the api-calls notice log-api-budget writes, so the hub can rank its spend. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed No security findings. critical-findings: 0 Scope read. The diff has 3 files: What I checked. The change moves the existing time-based
Spend. The change cuts GITHUB_TOKEN API calls only. It adds no billed resource and no hold. |
|
claude-review reviewed No findings. I read the diff, What I checked
Notes, not counted as findings
|
|
Unattended merge: risk HIGH at head |
|
Unattended merge: risk HIGH at head This refusal has stood unchanged at this head, so a person is needed: the pr-merge lane added the human-gated label. |
|
The pr-unblock lane stopped on this pull request and needs a person: a conflicted path is a workflow, submodule config or a settings file, which the lane does not resolve.
To resume, deal with the reason above, remove the gh workflow run pr-unblock.yml -R melodic-software/claude-code-plugins -f pr-number=10527 -f activity=resolve-conflicts |
…uns-prefilter Conflict in pr-require-checks.yml ci-status: both sides added the api-calls notice. Keep main's api_budget_emit_calls helper line over the branch's inline awk (same output), and point the branch's executing test at that one-line block. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…oncile-lost-runs-prefilter
|
The pr-unblock lane escalated this pull request as |
Post-merge mutation testingThe run's summary has the full report. |
No related issue: a GITHUB_TOKEN spend cut from the 2026-10-27 spend ranking, where maintenance-reconcile-lost-runs is #3 at about 8.1k calls a day.
Summary
The lost-run reconciler now reads a passed PR's pr-verify pass artifacts only when that PR's spec moved after the head's earliest checks run. The re-runs it plans are unchanged. ci-status now also writes the exclusive
api-callsnotice, so the hub can rank its spend.Calls per run.
api-callsnotice over 32 runs on 2026-10-27 (spend ranking, row 3).Measured cut. I ran the plan step (reads only) of the old and new reconcile.mjs back to back against live state, on a user token. A counting
fetchwrapper refused any write.Fix
prefilterSpecnow runs first over every passed PR, bounded by the earliestcreated_atamong the head's pr-require-checks runs.passStartsand the existing pre-filter, with the real pass starts, run only for the PRs it keeps.judgeSpecis unchanged.workflow_runof a completed pr-require-checks run at that head (pr-verify.ymlon:).specChangedweighs and none of them moved after the bound.run_started_at, but that is not safe. A label or body edit after a pass starts a newer checks run, and pr-verify then skips that head as already judged (pr-verify.yml concurrency comment). A spec edit between the pass and that newer run would be missed. A new test pins this case, and it fails under that bound.lanesstep now prints the sameapi-calls github-token=N not-modified=Mnotice the log-api-budget action prints, from the same reading file. The lanes-hold reader records into that file (API_BUDGET_TOKEN: github-token). The aggregate-results action's calls are not recorded, so N is a lower bound, like every other job's.LANE_RUN_PAGES = 5, so a single listing would fail the run today. With the cap raised it saves about 3 calls a run, about 140 a day. At about 900 runs a day it would cost more than the 9 listings.Verification
node --testin.github/scripts/maintenance-reconcile-lost-runs: 117 pass. The new tests are:node --testonlog-api-budget.test.mjs: 37 pass. A new test runs ci-status's notice block and compares its output with the action's.scripts/ci-ordered-skips.test.sh: 13 pass.scripts/check-affected.sh --tests: 10 passed and 6 skipped. It ran no test suites, because the 61 selected suites are left to their CI lanes..github/actions/resolve-config, onCannot find package 'ajv', because that package is not installed in this worktree.Related
🤖 Generated with Claude Code