Skip to content

pr-pipeline: a workflow-modified broker refusal should skip the activity, not fail it #7732

Closed

Description

@kyle-sexton

Problem

When pr-run-activity-write.yml runs an activity (seen with fix-docs) on a pull request that changes a workflow file, the lane broker refuses the token with 403 workflow-modified: .github/workflows/<file> differs from refs/heads/main. The job then fails instead of skipping. Seen on #7717 (fix-docs / run, pr-refine / fix-docs).

The failed check is not required, but the guardrails block-unresolved-pr-merge hook refuses any merge while a check is failing. So every pull request that changes a workflow file needs a human merge, even when ci-status is green and every thread is resolved.

Done when

  • A broker refusal with reason workflow-modified ends the activity as skipped or neutral, with the reason in the job summary, not as a failure.
  • A test covers that path.

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Oct 17, 2026
  2. github-actions commented on Oct 17, 2026

    @github-actions
    Contributor

    Thanks for the report. I understand this as: when the lane broker refuses a token with reason workflow-modified (the lane's workflow file differs from the default-branch tip), pr-run-activity-write.yml currently surfaces that as a job failure rather than a skip/neutral outcome, and since that check isn't required but block-unresolved-pr-merge blocks on any failing check, every PR touching a workflow file needs a manual merge override even when ci-status is green. The repro (#7717, fix-docs / run) and the "Done when" criteria (skip/neutral with the reason in the job summary, plus a covering test) give enough to act on. No missing information noted. No duplicate found among open issues searched.

    Automated triage. A maintainer reviews it.

  3. added and removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    No fields configured for Bug.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions