Skip to content

source-control:pull-request: bare 'Refs #N' opt-out clears the skill's local gate but not the real pr-issue-linkage validator #630

Closed

Description

@kyle-sexton

Lane: work · Triggering example: discovered while implementing #487 (PR #629, source-control 0.12.0 → 0.12.1).

Observed vs expected

plugins/source-control/skills/pull-request/reference/create.md §2.4.2 treats a bare Refs #N line as a valid closing-keyword opt-out for its own local gate. The real pr-issue-linkage reusable CI workflow (pinned ci-workflows@90f1c54 at time of writing) only accepts a genuine native GitHub closing keyword (Closes/Fixes/Resolves + #N) or one of the documented opt-out markers (No linked issue, No related issue:) — Refs #N is not in that set.

Observed: a PR body that satisfies the skill's own §2.4.2 opt-out check can still fail the real pr-issue-linkage CI gate, because the two acceptance sets diverge.
Expected: the skill's local opt-out marker set and the CI workflow's validator regex should accept the identical set of markers, so a PR the skill considers "gate-satisfied" always is.

Category

behavioral (contract mismatch between a skill's self-check and the CI gate it's meant to satisfy)

Suggested fix direction (not investigated in depth — pick one)

  1. Drop Refs #N from the skill's accepted opt-out set, matching the validator exactly.
  2. Extend the validator's accepted marker set to include Refs #N (requires a ci-workflows change per this org's cross-repo ownership — Actions-execution behavior lives upstream there).

Option 1 is the narrower, same-repo fix; option 2 changes shared CI behavior for every consumer.

Related

#487 (source, closes) · PR #629 (where this was found and documented in the PR body / create.md §2.4.1 prose as a known asymmetry, not fixed in that PR's scope)

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Jul 20, 2026
  2. kyle-sexton commented on Jul 20, 2026

    @kyle-sexton
    MemberAuthor

    This was generated by AI during triage.

    Triage — ready with noted decision.

    Single clear fork with the issue's own recommendation already load-bearing: option 1 (drop Refs #N from the skill's local opt-out set, matching the real pr-issue-linkage validator) is same-repo and narrow; option 2 (extend the validator to accept Refs #N) requires a cross-repo ci-workflows change affecting every consumer of that reusable workflow — out of this repo's ownership per this org's cross-repo convention, and a much larger blast radius for a self-inflicted mismatch.

    Decision defaulted: option 1 — veto before merge. Drop Refs #N from create.md §2.4.2's accepted opt-out set so the skill's local gate matches the real CI validator exactly.

  3. added
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    and removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Jul 20, 2026
  4. added theissue type on Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    status: readyTriaged, unblocked, and fully specified; eligible to pick up.

    Type

    Fields

    No fields configured for Bug.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions