Skip to content

ci: drop the zizmor self-repository ignores and take the auto-fix once actionlint understands $/ #4130

Closed as not planned

Description

@kyle-sexton

Tracking the revisit condition left behind by the zizmor 1.30.0 bump (#4021), so it does not depend on someone happening to read the comment in ci.yml.

Current state

zizmor 1.30 added the self-repository audit, which recommends GitHub's $/... reference form over the workspace-relative ./... form. It fires on every uses: ./.github/actions/checkout-with-base call site, and the lint lane treats any zizmor finding as a failure, so the bump could not land without addressing it.

The audit's advice could not be taken. Its auto-fix rewrites the call sites to $/.github/actions/checkout-with-base, and actionlint then rejects every one of them, so the lane goes red in a different step instead. Each site therefore carries a terse # zizmor: ignore[self-repository], with the reasoning recorded once above the Run zizmor step in .github/workflows/ci.yml.

Current suppression sites (7):

File Count
.github/workflows/ci.yml 4
.github/workflows/claude-security-review.yml 1
.github/workflows/dependabot-miro-bundle.yml 1
.github/workflows/silent-revert-canary.yml 1

Why it is still blocked

$/ is genuinely supported by GitHub Actions (changelog, 2026-07-21); a uses: value starting with $/ resolves to the workflow's own repository at the running commit, requires runner 2.336.0 or newer, and works everywhere ./ works. The blocker is the linter, not the platform.

actionlint does not yet parse it. Taking the auto-fix against current main produces 7 errors and exit 1:

.github/workflows/ci.yml:145:15: specifying action "$/.github/actions/checkout-with-base" in invalid format
because ref is missing. available formats are "{owner}/{repo}@{ref}" or "{owner}/{repo}/{path}@{ref}" [action]

actionlint v1.7.12 (released 2026-03-30) is the latest release, and no release note through v1.7.12 mentions $/ or self-repository syntax. actionlint reaches this repository through a SHA-pinned external action, so it cannot be moved from here:

uses: melodic-software/ci-workflows/.github/actions/actionlint@5776760254f8b63cba44e896f51604cb755350d9 # v0.22.2

Trigger condition

An actionlint release parses uses: $/... without the "invalid format because ref is missing" error, and the melodic-software/ci-workflows actionlint action is repinned to a version carrying it.

Steps when the condition is met

  1. Confirm the new actionlint accepts $/, ideally by running it over these four workflow files directly.
  2. Repin the melodic-software/ci-workflows/.github/actions/actionlint SHA in ci.yml to the release carrying it.
  3. Run zizmor --fix=safe --persona=regular -- . to rewrite the 7 call sites, or edit them by hand.
  4. Delete the 7 # zizmor: ignore[self-repository] comments and the explanatory block above the Run zizmor step in ci.yml, which exists only to justify them.
  5. Verify both linters are clean: zizmor exit 0 with no findings and no self-repository ignores counted, and actionlint exit 0.

Notes

  • Nothing here is urgent. The suppressions are narrowly scoped to one audit at one call-site shape and leave zizmor's other audits active; the self-repository finding is severity Low.
  • Do not reach for a repo-wide zizmor.yml disable: true instead. zizmor's own documentation calls disabling an audit a last resort, and it would hide the finding on future call sites too.
  • Adopting $/ is a small improvement beyond silencing the audit: it removes the ordering subtlety that dependabot-miro-bundle.yml documents, where the merge commit must be checked out before the composite action can resolve.

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Sep 12, 2026
  2. kyle-sexton commented on Sep 12, 2026

    @kyle-sexton
    MemberAuthor

    Two notes so nothing lives only in the session that filed this.

    Optional tidy-up, independent of the trigger condition. The explanatory comment above the Run zizmor step in ci.yml does not cite this issue, so the link is one-way: this issue points at the code, the code does not point back. Adding (#4130) to that comment block would close the loop. It is a one-line change needing a full PR cycle against a protected branch, which is why it was not bundled into #4021; fold it into whatever next PR already touches ci.yml rather than spending a cycle on it alone.

    The $/ rewrite is available early if someone wants it. It is mechanically ready now: zizmor --fix=safe --persona=regular -- . rewrites all 7 sites cleanly, and the only thing stopping it is actionlint. Taking it before the trigger condition is met means accepting a red lint lane, so it should not be done casually, but it is a deliberate choice someone could make rather than a blocked path. Re-measured against main at 17b914a1: 7 self-repository findings suppressed and zizmor exit 0 as shipped; with the fix applied, zizmor reaches exit 0 with no suppressions and actionlint goes to 7 errors and exit 1.


    Generated by Claude Code

  3. added
    needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.
    and removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Sep 27, 2026
  4. kyle-sexton commented on Sep 27, 2026

    @kyle-sexton
    MemberAuthor

    This was generated by AI during triage.

    Triage: human-gated (blocked on an external condition, needs a SHA repin).

    Verified 2026-09-27 against main at e509cb7b2:

    • Trigger condition not met. The latest actionlint release is still v1.7.12 (2026-03-30), the same version the issue names. No release since then parses uses: $/....
    • The pinned actionlint action has moved since filing: ci.yml now pins melodic-software/ci-workflows/.github/actions/actionlint at v0.27.1 (4610c31e); the issue body cites v0.22.2. That pin still wraps the same actionlint, so the blocker is unchanged.
    • The suppression count has drifted: there are now 8 # zizmor: ignore[self-repository] sites, not 7. ci.yml has 5, test-windows.yml 1, silent-revert-canary.yml 1, dependabot-miro-bundle.yml 1, and claude-security-review.yml has none. The explanatory block above the Run zizmor step is still there. Whoever does the work should re-count rather than trust the table in the body.

    Why a human has to act:

    • Step 2 repins a SHA-pinned external action (melodic-software/ci-workflows actionlint), and dependency SHA-pin changes are human-gated in this repo's autonomous lanes.
    • The work can't start until an actionlint release happens upstream, and no agent can make that happen.

    Brief (for when the condition is met):

    • Goal: switch every self-repository composite-action reference in the workflows from ./ to $/, and remove the zizmor self-repository suppressions plus the comment block that justifies them.
    • Precondition: an actionlint release accepts uses: $/..., and the ci-workflows actionlint action is repinned to a version that carries it.
    • Acceptance: zizmor exits 0 with no self-repository findings and no ignores for that audit; actionlint exits 0; no repo-wide disable of the audit is added.
    • Out of scope: the $/ rewrite before actionlint supports it (it would turn the lint lane red).

    Priority: priority: low, because the issue says nothing here is urgent and the finding is severity Low.

  5. added theissue type on Sep 27, 2026
  6. kyle-sexton commented on Sep 29, 2026

    @kyle-sexton
    MemberAuthor

    Reopened. This comes from the 2026-09-29 audit of the Cursor agent run. needs-human and priority: low stay; this issue is not to be closed until the revisit condition is met.

    Finding

    This issue is the tracker for a blocked revisit condition: an actionlint release that accepts uses: $/..., plus a ci-workflows actionlint repin. #4959 closed it, which moved the tracking into a ci.yml comment, the exact dependence the issue was filed to avoid. #4959 delivered only the optional tidy-up comment.

    Facts rechecked 2026-09-29

    • The latest actionlint release is v1.7.12 (2026-03-30).
    • ci.yml and the other workflows still carry 9 # zizmor: ignore[self-repository] sites (git grep on the fix branch: 6 in ci.yml, 1 each in dependabot-plugin-release.yml, silent-revert-canary.yml, test-windows.yml).
    • Acceptance (zizmor exits 0 with no self-repository ignores) is unmet.

    What happens next

    PR #5316 trims the ci.yml comment to a (#4130) back-reference and uses Refs #4130, never Closes.

    Revisit when: actionlint releases $/ support AND the ci-workflows actionlint action is repinned.

  7. kyle-sexton commented on Sep 29, 2026

    @kyle-sexton
    MemberAuthor

    Owner decision (2026-09-29): Leave this open and parked. Revisit when actionlint releases $/ support and the ci-workflows actionlint action is repinned. Do not take zizmor --fix=safe early, and do not close it.

    Next: nothing until the upstream actionlint release. Then an agent can do the $/ rewrite once the owner approves the SHA repin. needs-human stays for that repin approval. Re-count the self-repository suppressions before starting (9 as of 2026-09-29).

  8. kyle-sexton commented on Sep 30, 2026

    @kyle-sexton
    MemberAuthor

    Agent consensus under the owner's 2026-09-30 delegation (not reviewed by the owner; reversible): Keep this open and parked. The owner decided on 2026-09-29 to leave it open, revisit when actionlint releases $/ support and the ci-workflows actionlint action is repinned, not take zizmor --fix=safe early, and not close it. That decision stands. No owner question is pending. Trigger check today: the latest actionlint release is still v1.7.12 (2026-03-30), the newest default-branch commit (011a6d15, 2026-04-19) has no release, and actionlint issues #732 and #711 ($/ self-repository syntax) are both still open.

    Plan once an actionlint release accepts uses: $/...: (1) re-count the # zizmor: ignore[self-repository] sites (9 as of 2026-09-29); (2) repin the ci-workflows actionlint action once the owner approves the SHA; (3) run zizmor --fix=safe --persona=regular -- .; (4) delete the ignores and the explanatory block above the Run zizmor step; (5) confirm zizmor exits 0 with no self-repository ignores and actionlint exits 0.

    Human step: Kyle approves the SHA repin of the melodic-software/ci-workflows actionlint action after actionlint publishes a release with $/ support. needs-human stays for that approval.

    Resolved by consensus of three read-only researchers under the owner's standing instruction of 2026-09-30 to resolve owner-gated issues.

    Next: nothing until the upstream actionlint release. Then an agent does steps 1 and 3 to 5 and asks the owner only for the step 2 repin approval.

  9. kyle-sexton commented on Sep 30, 2026

    @kyle-sexton
    MemberAuthor

    Owner decision (2026-09-30): ratified. The owner approved the agent consensus above (headed "Agent consensus under the owner's 2026-09-30 delegation") in their own words: "I explicitly want you to do the recommended stuff here." It now stands as the owner's decision.

  10. kyle-sexton commented on Oct 18, 2026

    @kyle-sexton
    MemberAuthor

    Decision recorded.

    Question: About 70 # zizmor: ignore[self-repository] lines wait on an actionlint release that parses uses: $/.... Options: (a) keep it parked; (b) un-park, repin and run zizmor --fix=safe.

    Owner's answer: (a) The trigger is still unmet: the latest actionlint release is v1.7.12 (2026-03-30). Basis: gh release list -R rhysd/actionlint this session.

    The owner accepted this recommendation as item D17 of a 21-decision batch in an attended backlog-shaping session on 2026-10-18. The batch question: "Accept all 21 batch 7 decisions, with my change to D13 (#6008 goes to the lane, but you merge its PR because it edits AGENTS.md)? I post a 'Decision recorded.' comment on each issue." The owner answered: "Accept, with my D13 change (Recommended)".

    Posted by AI from the owner's answer in that session.

  11. added a commit that references this issue on Oct 24, 2026
  12. kyle-sexton commented on Oct 24, 2026

    @kyle-sexton
    MemberAuthor

    Closed by the owner's Backlog HITL session, 2026-10-24 (Q1 option a: close and watch with a schedule row). The actionlint-self-repository-watch row in .github/recurring-schedule.json (added in #9701) rechecks the trigger monthly and files a new issue when it fires; this body stays as that row's spec. To reopen: reopen this issue and say what changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.

    Type

    Fields

    No fields configured for Task.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions