Skip to content

review: sweep unit, bake the route phrases for the code-review and security-review lanes #4053

Closed

Description

@kyle-sexton

Parent

Refs #4047. Unit 6 of 9 (sweep unit for the review plugin, plan Phase 8). Predecessor: #4052 (testing sweep unit). Start only after #4052 has merged green.

Agent Brief

Type: Task

Summary: apply the store's integration values for the code-review and security-review rows (both proposed route: the CI lanes run under a pinned reusable workflow in another repository, and the security-review skill's tool allowlist has no Skill access) through the audit-native-overlap apply step. Phrase only, no Native step, no allowed-tools change.

Current behavior: neither CI lane skill carries a presence-gated phrase for the bundled code-review skill or the plugin-backed security-review built-in; the review plugin's quality-gate skill documents the overlap organically in its own body.

Desired behavior:

  • code-review: a description phrase carrying the gate token and the routing split (the bundled skill is a session-driven review of the current diff or a named PR with mutating flags; this skill is a non-interactive CI lane a reusable workflow invokes for one pull request), within the per-entry cap.
  • security-review: the same shape for the plugin-backed security-review built-in.
  • Baked flags on both rows, the view regenerated, the skill-quality check passing for both skills, the next minor of review at PR time with a CHANGELOG entry stating the rules.

Key interfaces:

  • The two skill descriptions; no body section and no allowed-tools edit.
  • The two store rows and the generated view.

Acceptance criteria:

  • bash plugins/skill-quality/scripts/check-skill.sh <skill> passes for code-review and security-review.
  • python3 plugins/claude-ops/skills/audit-native-overlap/scripts/overlap.py self-check --upstream-sha ed404106fcd80ba98ecb7c851e531dcb626d13b7 exits 0; jq -r '.rows[] | select(.component.plugin=="review") | .integration' docs/native-surfaces/records.json prints route twice.
  • grep -c "resolves in your session" plugins/review/skills/code-review/SKILL.md and the same for security-review each print at least 1, inside the frontmatter description.
  • The PR is a draft, quotes the two store rows, and flips to ready when green; the unit closes only when the PR merges green.

Out of scope:

  • Any row or skill outside the review plugin; granting Skill access to a CI lane; changing either verdict.

Blocked by

Activity

  1. added theissue type on Sep 10, 2026
  2. kyle-sexton commented on Sep 11, 2026

    @kyle-sexton
    MemberAuthor

    Deferred; scope narrowed (2026-09-11). The Boundary sections for the code-review and security-review rows landed with native-references 1.1.0 (#4058). Both rows are route, so what remains is the gate-token description phrase on each skill and the baked flags; the security-review row's reason rests on the CI harness owning the tool roster and the native command diffing against origin/HEAD, not on allowed-tools. Still blocked by #4049.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.

    Type

    Fields

    No fields configured for Task.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions