Repository navigation
Labels
agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.Fully specified and briefed; eligible for autonomous pickup from the frontier.
Description
Parent
Refs #4047. Unit 1 of 9 (tooling fix, plan Phases 1 to 3). Predecessor: none.
Agent Brief
Type: Bug
Summary: the inventory extractor's bundled-skill lane returns empty on Claude Code 2.1.263, which makes every native-overlap run report broken; recover the lane, report integrity per lane in both engines, close the reverse-parity blind spot, and seed the two missing pairs.
Current behavior:
- The extractor selects the single longest printable run of the binary and looks up the registrar through the CJS getter shape
registerBundledSkill:()=>xu. The 2.1.263 binary is a// @bun @bytecodelayout fragmented into thousands of printable runs; the getter shape is gone (an ESM export listeo as registerBundledSkillnames the registrar now), and registrations sit in runs as small as 1.3 KB, so the lane resolves nothing and the whole run isbroken. - Integrity is all-or-nothing: one failed lane marks the entire extraction
broken, and the overlap engine'sdetectexits 1 while still writing candidates. - The overlap self-check cannot see a description that names a bundled surface behind a presence condition ("where the bundled design skill is available") without the gate token.
- Two store rows (
doctorandskill-doctoragainstclaude-ops:audit-skill-visibility) are absent from the seeded canonical pairs, so a consumer repository'sdetectnever proposes them. - Two bundled registrations can share one name (on 2.1.263,
design: the canvas skill registered byregisterDesignCanvasSkill, model-invocable, and the claude.ai/design hub, model-disabled), and a name-keyed extraction reads whichever it meets last, so a per-registration field such asdisable_model_invocationis unreliable for that name.
Desired behavior:
- Region rule: from the first bundle marker to end of file, every printable run of at least 256 bytes, found with one regex pass over
[\t\n\r\x20-\x7e]{256,}, joined with newlines; the extraction records run count, joined bytes, the region rule, registration tokens below the floor (counted, never silently lost), and elapsed seconds. The longest-run path stays as the fallback when no marker is found. Measured on the real binary, this floor recovers the named surfaces in about 4 seconds; a 64 KiB floor recovers 13 of 33 names and a 1-byte floor takes a minute. - Registrar discovery order: CJS getter, then the ESM export list (
<ident> as registerBundledSkill), then the canary registration (the callee immediately preceding({name:"doctor",aliases:["checkup"]); the notes record which route resolved (export-map,esm-export,canary); with none, the lane is broken with the existing error text. - Hoisted-constant names resolve by locality: the nearest preceding
ident="kebab"binding, a farther binding never winning over a nearer one (theehrpdphantom is the negative case); a single-character identifier is trusted only when that binding lies within a 64 KiB window; no preceding binding is unresolved, never guessed. Bundle markers are not module boundaries in the bytecode layout (the constants sit megabytes and about 170 marker occurrences ahead of their registrations), so locality is measured in bytes. A loop or template-literal registration is recorded as adynamic_rosternote; a registrar-identifier call whose object carries noname:is another module's function and is counted apart. - Each registration records
user_invocable,disable_model_invocation,terminal_oriented, andsurvives_kill_switchwhen present. A function-valueddisable_model_invocation(theverifyregistration's shape) is recorded astruewith the key listed underflag_driven, matching the binary's own serializer. On 2.1.263,doctorreads model-disabled and terminal-oriented;simplifyandruncarry no invocation-control field. - Same-name bundled collision: two distinct bundled registrations sharing one name are both kept under
bundled_skills.<name>as a list of registrations, each withcollision: true, named inbundled_skill_notes.collisions; never merged and never last-writer-wins. The fixture is the twodesignobjects. - The registrar-shaped-export advisory scan also matches the ESM form, and the known-registrar set gains
registerDesignCanvasSkillandregisterWorkflowAuthoringSkill. - Integrity carries a
lanesblock (builtin_commands,bundled_skills,plugin_backed, each{status, problems, advisories}); the top-level status is the worst lane, wherebrokenmeans every lane is broken or the binary is unreadable and a run with at least one healthy lane is at mostdegraded.plugin_backedgains a canary (security-review). Existing exit mappings (ok0,degraded3,broken1) are unchanged in bothinventory.py --self-checkandoverlap.py detect. detecton an inventory with one broken lane states per-lane floors and marks every candidate whose lane is broken withre_derivable: false, deciding the lane by the seeded class when the native name is absent from the extraction and by the observed class when present, in both directions on a collision; session-provided and marketplace candidates carryre_derivable: null. Where a bundled name carries a registration list,detectlists every registration in the candidate's evidence with its invocation mode. An inventory withoutlaneskeeps today's behaviour.- The self-check emits an advisory (exit 3, never a break) for a frontmatter description that names a native surface by class word (
bundled,built-in,plugin-backed built-in,session-provided) plusskillorcommandinside awhen,where, orifclause with an availability word and no gate token in that clause; a seam-phrasing "if that plugin is installed" clause, a Not-for clause with no presence condition, and a plain mention with no availability word are not flagged. --upstream-sharepeats, one value per upstream repository the store cites; a recorded commit matches when any provided value matches it.- The two
audit-skill-visibilitypairs are seeded into the canonical pairs with awhy. - Skill bodies: the audit-native-overlap rule "if it reports broken, the report carries no native-side counts at all" becomes per-lane (counts omitted only for a broken lane, the lane and cause named); the inventory skill's integrity paragraph and its extraction reference describe the lanes block and the registration-list shape.
- Evals: this repository's evals are
evals.jsonin the skill-quality format and the CLI eval runner consumes a different case format, so "evals pass" means the deterministic evals-quality lint and the schema check pass after any expectation naming the old build or the old integrity wording is updated; thenVALIDATED_AGAINSTmoves to2.1.263. - Windows: where a Windows host with the 2.1.263
claude.exeis reachable, run the self-check there and record it; otherwise the CHANGELOG entry states the Linux-only validation basis and that the PE path is covered by a fixture. - Version: next minor of
claude-opsat PR time; CHANGELOG states the rules, never the incident.
Key interfaces:
read_bundle()(extractor): returns the joined source under the new region rule; gains its first unit tests (fragmented runs, PE container, legacy single run, a registration below the floor counted not lost).discover_registrar_route()andextract_bundled_skills(): three discovery routes, locality-based name resolution, the four new per-registration fields, the same-name registration list,registrations_of().check_integrity(): returnslanes; the top-level status is the worst lane.overlap.py cmd_detect(): readslaneswhen present;re_derivableper candidate; registration-list aware.overlap.py check_presence_mentions(): the new advisory for presence-gated mentions without the gate token.
Acceptance criteria:
-
python3 plugins/claude-ops/skills/inventory/scripts/test_inventory.pyexits 0 and contains at least fourtest_read_bundletests and one same-name collision test. -
time python3 plugins/claude-ops/skills/inventory/scripts/inventory.py --binary-only --out /tmp/inv.jsonexits 0 in under 30 seconds (measured about 14 seconds on the Linux build);jq -e '[.bundled_skills.doctor, .bundled_skills.simplify, .bundled_skills.run, .bundled_skills.design, .bundled_skills["code-review"]] | all(. != null)' /tmp/inv.jsonandjq -e '.plugin_backed["security-review"] != null' /tmp/inv.jsonprinttrue. -
jq -e '.bundled_skills.doctor.disable_model_invocation == true and .bundled_skills.simplify.disable_model_invocation == null and .bundled_skills.doctor.terminal_oriented == true' /tmp/inv.jsonprintstrue;jq -r .bundled_skill_notes.registrar_route /tmp/inv.jsonprintsesm-export;jq -r .integrity.status /tmp/inv.jsonprintsokordegraded; the bundled-skill keys do not containehrpd. -
jq -e '.bundled_skills.design | (type == "array" and length == 2) and (map(.disable_model_invocation // false) | sort == [false, true])' /tmp/inv.jsonprintstrue. -
python3 plugins/claude-ops/skills/audit-native-overlap/scripts/test_overlap.pyexits 0; a fixture inventory withlanes.bundled_skills.status == "broken"and healthy other lanes makesdetectexit 3 and mark at least one candidatere_derivable: false. -
grep -c "no native-side counts at all" plugins/claude-ops/skills/audit-native-overlap/SKILL.mdprints 0. -
python3 plugins/claude-ops/skills/audit-native-overlap/scripts/overlap.py self-check --upstream-sha ed404106fcd80ba98ecb7c851e531dcb626d13b7 --upstream-sha d7dbd9a09f59775726ed14bbea8fc9dfdff62f7bexits 3 with no problems, and its advisories are the version-drift advisory plus exactly two reverse-parity advisories namingvisualization:visualizeandprototype:explore-directions. -
jq '.pairs | length' plugins/claude-ops/skills/audit-native-overlap/reference/canonical-pairs.jsonprints 16 and a pair withnative.name == "skill-doctor"exists. -
grep -n 'VALIDATED_AGAINST = "2.1.263"' plugins/claude-ops/skills/inventory/scripts/inventory.pymatches;bash plugins/skill-quality/scripts/check-evals-quality.sh plugins/claude-ops/skills/inventory/evals/evals.jsonexits 0;scripts/affected-tests.sh --runpasses; the claude-ops version is above 0.47.1 with a CHANGELOG entry. - The PR is opened as a draft, its body follows the PR-body contract and quotes the two seeded pairs, and it flips to ready when green.
Out of scope:
- The
integrationfield, the two new grammars, and any convention edit beyond none: those are the policy unit (unit 2). - Editing any skill body's routing text or any store row's verdict.
- The follow-up items listed on the parent container.
Blocked by
None; can start immediately.
Metadata
Metadata
Assignees
Labels
agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.Fully specified and briefed; eligible for autonomous pickup from the frontier.
Type
Fields
No fields configured for Bug.
Activity
docs(topics): record the spec container and close Phase 0 of the audi…