Skip to content

code-metrics: follow-ups deferred from the 0.1.0 plugin build (#3766) #3768

Closed
17 of 17 issues completed
Closed

Description

@kyle-sexton

Follow-ups carried out of the code-metrics plugin's first release (PR #3766), none of which blocks that PR. Each is independent; take them as separate PRs.

Operator decisions

  • Q24, the two convention adopter rows. The marketplace's per-plugin conventions registry needs the plugin's adopter rows once the operator settles which conventions it adopts; the README's "Known gaps" section says so until then.
  • Q23, a skill-doctor row in docs/native-surfaces/records.json. Needs an upstream-source pin (the anthropics/claude-code CHANGELOG commit SHA for the 2.1.261 /skill-doctor addition), which was outside the build session's repository scope. The audit-skill-visibility routing already names the surface behind a presence gate (claude-ops 0.42.8).

From the plugin-quality audit (packet run 20260905T173832Z)

  • Generate reference/config.md's key table from scripts/config-defaults.json so the two surfaces cannot drift (the setup template is already bound to the defaults by a test; the reference and the SKILL.md bodies remain prose copies).
  • Root-relative file fields in the code-metrics/v1 schema. Today every path is relative to the working directory the audit ran from; a consumer comparing two reports from different directories has to normalize.
  • cobertura.py reads only the first <source> root; gcovr emits several for multi-root builds. Read all of them (the audit-coverage Gotchas document the limit).
  • The coverage join's trailing-name fallback can bind A.run to B.run inside one file when the artifact carries only the short name; prefer a range-overlap tie-break.
  • Invoke each skill through the Skill tool in a consumer repository to observe pre-computed context rendering, the quoted-path allowed-tools match, and description triggering; the build session only ran the scripts directly.

From the phase verifiers

  • After a total sanctioned-replication exclusion, summary.files counts surviving rows only while the scope header shows the file count; consider counting the excluded instances' files in the summary.
  • audit-type-debt.test.sh hardcodes the collector-name list for its tool-free PATH; a ladder tool added later must be added there too.
  • Three skill descriptions sit within 20 codepoints of the 1024-codepoint spec field cap (principles, audit-complexity, audit-coverage).

Out of scope by design (recorded, not follow-ups)

  • The C# complexity lane (deferred behind a runtime probe of Microsoft.CodeAnalysis.Metrics).
  • A Bash function-range collector for CRAP.

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Sep 5, 2026
  2. kyle-sexton commented on Sep 6, 2026

    @kyle-sexton
    MemberAuthor

    This was generated by AI during triage.

    Claimed for triage by autonomous lane instance vm-triage-202609050304. Lease expires 2026-09-06T19:40:00Z. This is a triage claim only, not an execution claim; the item stays unassigned and available to the worker lane once briefed.


    Generated by Claude Code

  3. kyle-sexton commented on Sep 6, 2026

    @kyle-sexton
    MemberAuthor

    This was generated by AI during triage.

    Triage verdict: decomposed

    Category: Task. State: oversized for a single brief → decomposed into ten native sub-issues. Parent role: work-map container; it tracks the set and is not itself claimable work.

    Routed to decomposition rather than briefed as one item because the body carries ten independent follow-ups spanning parsers, a published schema, documentation binding, test hygiene, an operator decision, and a manual QA pass. The issue says so itself: each is independent and wants its own PR. A single brief would have been unworkable, and a cold agent picking up the parent could not have known where to stop.

    Verification before slicing

    Spot-checked the claims against current main rather than taking them on trust. Confirmed: the plugin ships the seven skills described; the configuration defaults file and the configuration reference both exist as separate surfaces, the reference table hand-maintained; the known-gaps section records the deferred convention adopter rows; the native-surfaces record carries the note recording the owed upstream pin and the reason it could not be taken.

    The Cobertura defect was confirmed in the code, not just in the report: the parser collects every declared source root into a list and then applies only its first element to relative class filenames. The remaining items were read as described and matched their surfaces.

    The ten slices

    Frontier first, unblocked items at the top.

    # Slice Type Class Priority
    #3839 Cobertura: resolve filenames against every declared source root AFK scoped medium
    #3840 Coverage join: range tie-break instead of trailing name AFK scoped medium
    #3841 Generate the config reference key table from the defaults file AFK scoped medium
    #3843 Reconcile the summary and scope-header file counts under total exclusion AFK scoped low
    #3844 Derive the type-debt suite's tool-free PATH from the collector ladder AFK scoped low
    #3845 Recover headroom in three descriptions, guard the spec cap AFK mechanical low
    #3846 Pin the upstream source for a dedicated skill-doctor row AFK scoped low
    #3842 Root-relative file paths in the report schema HITL structural medium
    #3847 Settle which conventions the plugin adopts, add adopter rows HITL scoped low
    #3848 Exercise every skill through the Skill tool in a consumer repo HITL read-only medium

    Seven are autonomous-eligible and unblocked; three need a human.

    Why the three are human-gated

    Sequencing note

    #3842 touches code adjacent to #3839 and #3840; taking it after them avoids a needless conflict. #3848 is most informative once #3845 and #3841 have landed, since both change what a QA pass would observe. Neither is a hard dependency, so no blocking edges were set.

    Not filed

    The two items the parent records as out of scope by design (the deferred C# complexity lane and the Bash function-range collector for the composite metric) were deliberately not turned into sub-issues. The parent records them as decisions, not as work, and filing them would convert a recorded decision into a backlog obligation nobody agreed to.

    This parent stays open as the container. Per the decomposition contract it was not closed and its body was not modified.

    Triage claim released by vm-triage-202609050304.


    Generated by Claude Code

  4. 12 remaining items

  5. kyle-sexton commented on Sep 29, 2026

    @kyle-sexton
    MemberAuthor

    From the 2026-09-29 audit of the Cursor run. This work-map stays open. Recording what PR #5142 did and did not satisfy, so lanes do not re-pick finished bullets.

    Lanes: check sub-issue state before picking up a parent bullet.

  6. kyle-sexton commented on Oct 1, 2026

    @kyle-sexton
    MemberAuthor

    Closing at the owner's direction on 2026-10-01 ("If there's anything that's old, not relevant, or not needed, we can close those"), after a read-only check of every child.

    All ten follow-up slices (#3839 to #3848) and the later audit slices (#3993 to #3998, #4067) are closed with merged PRs. The config-reference item (#3841) shipped as a verify gate, not a generator: #3912 added scripts/check-code-metrics-config-reference.py and wired it into ci.yml, pinning the key set and defaults against config-defaults.json; the prose column stays hand-written on purpose. The two out-of-scope items (C# complexity lane, Bash function-range collector) were never follow-ups.

  7. added
    spec-containerSpec container: sub-issues are its work items (/work-items:decompose and /work-items:ship).
    and removed on Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    spec-containerSpec container: sub-issues are its work items (/work-items:decompose and /work-items:ship).

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions