You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
CI: add a repo-wide gate rejecting exec-form hooks whose command is a bare non-portable executable name #2569
This defect class has now shipped three times in disk-hygiene alone, and each fix was verified by a test that encoded the defect as its contract.
The class
An exec-form hook (args present) resolves command as a bare PATH lookup. Per the hooks reference: "On Windows, exec form requires command to resolve to a real executable such as a .exe." Two Windows spellings fail:
"command": "bash" — resolves to the WSL relay System32\bash.exe before Git Bash; dies with execvpe(/bin/bash) failed.
"command": "python3" — commonly the zero-length WindowsApps\python3.exe App Execution Alias stub.
A failed hook launch is non-blocking, so a PreToolUse gate built this way silently enforces nothing.
plugins/claude-config/skills/audit/reference/audit-checklist.md Category D already carries this as an error row — and disk-hygiene violated it anyway, because a checklist a human reads is not a gate.
Proposal
Add scripts/check-hook-exec-form.sh plus a self-test, modelled directly on the existing scripts/check-hook-userconfig-argv.sh gate (same scope rules: default hooks/hooks.json, manifest-pointed hook configs, inline manifest hooks objects — and it should additionally cover SKILL.md / agent frontmatter hooks, which the userconfig gate does not). Fail on any exec-form hook whose command contains no path separator and is not on a small allowlist of names that are real executables on every targeted platform (node, python via an absolute path, etc.), with a documented escape-hatch allowlist file that can only shrink.
Wire it as its own CI job with the self-test-first, fail-closed pattern the userconfig-argv gate uses.
Activity
docs(disk-hygiene): assess shell-form launch in the security records (#…
fix(disk-hygiene): launch wired hooks in shell form, reviving the dea…
fix(ci): fail the exec-form gate closed on inputs it cannot read (#2569)
fix(ci): accept quoted YAML spellings of the frontmatter hooks key (#…
fix(ci): decode and fail closed instead of enumerating YAML spellings (…
fix(disk-hygiene): launch the skill-scoped guard in shell form (#2568) (
feat(ci): gate exec-form hooks against bare command names (#2569)
fix(ci): fail the exec-form gate closed on inputs it cannot read (#2569)
fix(ci): accept quoted YAML spellings of the frontmatter hooks key (#…
fix(ci): decode and fail closed instead of enumerating YAML spellings (…
fix(ci): read hook frontmatter with a real YAML parser (#2569)
fix(ci): drop a pull-request back-reference from a test comment (#2569)
fix(ci): refuse an ambiguous duplicate key instead of taking the first (
fix(ci): apply the duplicate-key check to merged mappings too (#2569)
fix(claude-ops): emit plugin ids from fleet-state.sh instead of a han…
docs: explain CI exec-bit=failure and the Windows filemode trap in AG…