Skip to content

pr-pipeline: issue lane opens a stack layer on an open blocker pull request #17539

Description

@kyle-sexton

Refs #15410

Problem

The issue lane opens its pull request on the default branch only (.github/scripts/work-resolve-issue/report-outcome.mjs), and .github/scripts/work-resolve-issue/check-blockers.mjs skips an issue while any blocker is still open. So an issue whose blocker already has an open pull request waits until that pull request merges, even though the lanes now accept a native stack layer whose stack base is main (#15400) and the merge lane is gaining a path that lands the bottom layer of such a stack (#15410).

What #15410 left out

The owner's decision on #15410 (option B, 2026-11-17) scoped that issue to the merge lane only and split issue-lane stacking out to this issue. Its second done-when line and refinement question 4 move here:

  • When the blocker has an open pull request, the issue lane builds on that pull request's branch and opens the new pull request as a stack layer on it.
  • The blocker's open pull request must pass the same trust checks as any lane input before the lane builds on it: same repository, a listed author or the lanes App, base main or a layer of a stack on main, and no do-not-merge.
  • Creating a stack needs the stack API that gh stack link calls, not the extension, in the runner.
  • A pull request opened into another branch before it joins a stack gets no branches: [main] workflows (ci-status) until a new event, so the lane must link the stack before or at pull request creation.
  • Unverified: whether a lanes App installation token can create a stack. Per the decision, this issue waits for a sandbox test of that in melodic-software/pr-pipeline-sandbox.

Refinement question 4 on #15410 recommended: if an App token cannot create a stack, skip the issue and keep agent-ready, so it re-fires once the blocker merges (check-blockers.mjs already skips and keeps agent-ready while a blocker is open). That recommendation is not decided; it is an open design point here.

Done when

  • A sandbox run in melodic-software/pr-pipeline-sandbox shows whether a lanes App installation token can create a native stack through the stack API, linked from this issue.
  • If it can: the issue lane opens a stacked layer on an open blocker pull request that passes the trust checks above, and still skips when it does not; tests cover both.
  • If it cannot: the outcome and the chosen fallback are recorded here, decided by the owner.

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 19, 2026
  2. github-actions commented on Nov 19, 2026

    @github-actions
    Contributor

    Size: Large
    Complexity: High
    Uncertainty: Unknown
    Flags: intent
    Blocked by: none
    Blast radius: the issue lane's blocker check and its pull request opening step (check-blockers.mjs, report-outcome.mjs), plus the stack API call and tests. The lane runs, and every issue with an open blocker pull request is affected.
    Reversible: yes; revert the change and the lane goes back to skipping an issue while its blocker is open.
    Open questions:

    1. If a lanes App installation token cannot create a native stack, what should the issue lane do for an issue whose blocker has an open pull request? The issue says the pr-pipeline: merge and issue lanes for native stack layers #15410 recommendation is "not decided".
      RECOMMENDED: skip the issue and keep agent-ready, so it re-fires once the blocker merges. Basis: check-blockers.mjs already does this, so it adds no new behavior or trust surface.
      To answer, post a comment that starts with this line:
    **Decision recorded.** <answer>
    

    I read this as a feature: let the issue lane open its pull request as a stack layer on a blocker's open pull request. The lane would do this only when that pull request passes the same trust checks as other lane input. Nothing here duplicates another open issue. #15410 is the related merge-lane work, and no merged pull request fixes this.

    The first done-when item is a sandbox run in melodic-software/pr-pipeline-sandbox, which an unattended lane run can't do. It needs a person, or a host run, to do it and link the result. The implementation work depends on what that run shows.

    Automated triage. A maintainer reviews it.

  3. melodic-automation-lanes commented on Nov 19, 2026

    @melodic-automation-lanes
    Contributor

    The triage verdict left this issue at needs-owner-decision:

    • flagged: intent
    • held by needs-owner-decision
    • no lanes App verdict comment shows whether an earlier verdict was flagged

    Reason: intent

  4. melodic-automation-lanes commented on Nov 19, 2026

    @melodic-automation-lanes
    Contributor

    Refinement. A read-only run explored this repository, searched its issues and pull requests, and read the allowed docs to draft what follows. On an issue a listed human filed, it counts as the issue's spec once posted, while unedited; it is still model text, so check it.

    Intended outcome: The issue lane opens its pull request as a native stack layer on an open blocker pull request that passes the trust checks, if a lanes App token can create a stack; otherwise it keeps skipping and leaves agent-ready.

    Dependencies

    • #​15410: merge-lane path that lands the bottom layer of a stack on main
    • A sandbox test in melodic-software/pr-pipeline-sandbox of whether a lanes App installation token can create a stack

    Related work

    Open questions

    1. If a lanes App installation token cannot create a native stack, should the issue lane skip an issue whose blocker has an open pull request and keep agent-ready?
      RECOMMENDED: Yes. Skip and keep agent-ready, so the issue re-fires once the blocker merges. This is the current behavior and adds no trust surface. Basis: .base/.github/scripts/work-resolve-issue/check-blockers.mjs:163
    2. Who runs the sandbox test of stack creation with an App token, and where is the result recorded? An unattended run cannot do it, and the work cannot be specified until it is done.
      RECOMMENDED: The owner or a host run does it in melodic-software/pr-pipeline-sandbox and links the result here. After that, refine again with the outcome. Basis: judgment
    3. Should the work be split into the sandbox verification (a person) and the implementation (a lane run) as separate issues, with the implementation written as a checkable task list once the verification result is known?
      RECOMMENDED: Yes. Make the verification a person-only check, and put the implementation criteria in a task list after the result is known. Basis: judgment
    4. When the lane opens a PR on the blocker's branch, which base does it use, and what does it do if the blocker's PR later merges or closes before the stack is linked?
      RECOMMENDED: Base the new PR on the blocker's head branch, link the stack at or before PR creation, and skip with agent-ready kept if the blocker PR is closed or changed in the meantime. Basis: .base/.github/scripts/work-resolve-issue/report-outcome.mjs:2828

    Sources read

    • /home/runner/work/claude-code-plugins/claude-code-plugins/refine-data/context.json: issue body, triage and candidates; no Decision recorded comment exists
    • /home/runner/work/claude-code-plugins/claude-code-plugins/.base/.github/scripts/work-resolve-issue/report-outcome.mjs:2828: the lane opens its PR with base set to the default branch (or a given base) through POST pulls
    • /home/runner/work/claude-code-plugins/claude-code-plugins/.base/.github/scripts/work-resolve-issue/check-blockers.mjs:163: the run is skipped and agent-ready kept while a blocker still blocks

    To answer, post a comment that starts with this line:

    **Decision recorded.** <answer>
    

    Automated refinement by the lanes App. Answer with a comment whose first line is **Decision recorded.**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs-owner-decisionAwaiting a human or maintainer judgment call.needs-triageNot yet classified. Floor until a type and one priority tier are set.

    Fields

    Work status

    needs-owner-decision

    Priority

    medium

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions