Skip to content

fix(ci): run the cross-plugin source drift check in pre-push check-affected #12985

Closed

Description

@kyle-sexton

Problem

The pre-push check-affected run passed on PR #12954's branch, but CI's check-plugins job then failed on scripts/check-cross-plugin-source-drift.sh --check: a new shared copy (reference/one-way-doors.md in planning and review) was not in scripts/cross-plugin-source-registry.txt. scripts/check-affected.sh neither runs that check nor lists it under its "CI only" lines, so a branch that adds a cross-plugin copy learns about the registry only after a CI round (about 10 minutes here).

Fix

Run scripts/check-cross-plugin-source-drift.sh --check from check-affected.sh when the change set touches scripts/shared-copies.txt, lib/, or any file under plugins/*/ that another plugin carries byte-identical. If it is too slow for pre-push, list it under the "CI only" lines so the gap is visible.

Acceptance criteria

  • A branch that adds a byte-identical file to two plugins without a registry entry fails check-affected before the push, or check-affected names the check as CI only.

Related

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 3, 2026
  2. github-actions commented on Nov 3, 2026

    @github-actions
    Contributor

    Proposed work class: work-class: scoped
    Basis: automated intake triage; the lanes App applied this class.

    Size: Small
    Complexity: Low
    Uncertainty: Known
    Flags: none
    Blocked by: none

    Understood: scripts/check-affected.sh doesn't run scripts/check-cross-plugin-source-drift.sh --check and doesn't list it as CI only. A branch that adds a cross-plugin shared copy therefore fails in CI after passing pre-push. The fix is either to run that check when the change set touches shared copies, or to list it under the "CI only" lines. The acceptance criterion is exact and nothing is missing. I found no duplicate among the open issues.

    Automated triage, applied by the lanes App.

  3. added and removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 3, 2026
  4. added
    admission-deferredAdmitted but waiting for WIP room; the hourly work-unblock sweep labels it agent-ready.
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    and removed
    admission-deferredAdmitted but waiting for WIP room; the hourly work-unblock sweep labels it agent-ready.
    on Nov 3, 2026
  5. melodic-automation-lanes commented on Nov 4, 2026

    @melodic-automation-lanes
    Contributor

    This records a re-fire of an earlier refusal, not a new refusal. The lanes kill switch stopped run 41738023849, the work-resolve-issue run that agent-ready started, before it did any work; that run ended at 2026-11-03T23:46:49Z. work-unblock has now removed and added agent-ready back to start a fresh run. A kill-switch refusal is no fault in this issue or the lanes, so it never counts against later re-fires; after limits.limit-stops-per-issue of them since a person last added agent-ready or a run last reported, work-unblock waits longer before each one, up to 24 hours.

  6. added
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    and removed
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Nov 4, 2026
  7. 2 remaining items

  8. added
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    and removed
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Nov 4, 2026
  9. github-actions commented on Nov 4, 2026

    @github-actions
    Contributor
    No description provided.
  10. github-actions commented on Nov 4, 2026

    @github-actions
    Contributor
    No description provided.
  11. melodic-automation-lanes commented on Nov 4, 2026

    @melodic-automation-lanes
    Contributor

    The work-resolve-issue run that agent-ready started waited in its slot past a change to its lane workflow files on main, so it stopped before any model turn. The run's report-outcome removed and added agent-ready back to start a fresh run on main's workflow files. If this run ends the same way, it re-fires the issue again, waiting longer each time.

  12. added
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    and removed
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Nov 4, 2026
  13. melodic-automation-lanes commented on Nov 4, 2026

    @melodic-automation-lanes
    Contributor

    This records a re-fire of an earlier refusal, not a new refusal. The lanes kill switch stopped run 41756369166, the work-resolve-issue run that agent-ready started, before it did any work; that run ended at 2026-11-04T01:49:51Z. work-unblock has now removed and added agent-ready back to start a fresh run. A kill-switch refusal is no fault in this issue or the lanes, so it never counts against later re-fires; after limits.limit-stops-per-issue of them since a person last added agent-ready or a run last reported, work-unblock waits longer before each one, up to 24 hours.

  14. added
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    and removed
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Nov 4, 2026
  15. github-actions commented on Nov 4, 2026

    @github-actions
    Contributor
    No description provided.
  16. github-actions commented on Nov 4, 2026

    @github-actions
    Contributor
    No description provided.
  17. removed
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Work status

    agent-ready

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions