Skip to content

feat(security): hold agent App changes to azure-iac's privileged paths #11044

Closed as not planned

Description

@kyle-sexton

Parent: #10849

azure-iac holds the agent App's own registration and vault (azure-iac#93-#95) and deploys Azure resources, which can bill the owner. The agent App is installed on all repositories, and azure-iac has no trust-path hold. This slice wires the shared hold (ci-workflows pr-require-checks-trust-paths.yml v0.67.2) into azure-iac with a .github/trust-path-hold.json covering its privileged paths, or clears it with evidence that no App-reachable path exists.

Done when

  • azure-iac calls the pinned hold with a reviewed path list, and an App-authored change to a held path fails ci-status.
  • Or this item is closed with evidence that no App-authored merge reaches a deploy, credential or billing path.

Activity

  1. github-actions commented on Oct 29, 2026

    @github-actions
    Contributor

    Proposed work class: work-class: scoped
    Basis: automated intake triage; the lanes App applied this class.

    Size: Small
    Complexity: Low
    Uncertainty: Knowable
    Flags: none
    Blocked by: none

    Understood: wire azure-iac into the shared trust-path hold with a reviewed .github/trust-path-hold.json, so an App-authored change to a deploy, credential or billing path fails ci-status. Alternatively, show with evidence that no App-authored merge can reach such a path. Either outcome satisfies the done-when.

    The earlier owner direction removed path holds until open issues reach 0. The reopen comment says this issue covers App reach into deploy and billing paths. No **Decision recorded.** comment settles whether the hold should land now, so a maintainer should confirm that before the work starts. First step: inventory azure-iac's App-reachable paths, then pick the hold or the evidence exit.

    No duplicates found.

    Automated triage, applied by the lanes App.

  2. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Oct 29, 2026
  3. added
    needs-owner-decisionAwaiting a human or maintainer judgment call.
    and removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    on Oct 29, 2026
  4. melodic-automation-lanes commented on Oct 29, 2026

    @melodic-automation-lanes
    Contributor

    Not admitted to the issue lane: its title or stated work names a charge (billing), which needs an owner decision. Admission takes the issue once each of those is met, when intake triages it again (.github/actions/resolve-config/admission-rules.json).

  5. melodic-automation-lanes commented on Oct 29, 2026

    @melodic-automation-lanes
    Contributor

    The latest triage verdict holds nothing: admission moved the issue to status: needs-decision; its comment says why.

  6. kyle-sexton commented on Oct 29, 2026

    @kyle-sexton
    MemberAuthor

    Closing as not planned. Owner decisions 2026-10-29, Q15: "We shouldn't really have any path restrictions at all... like that is just bullshit friction" and "We can go in and harden later"; Q16: "There should be no path restrictions. We can add that in later." Standing direction s10: holds that guard against our own actors (trust-path, path and person-approval holds, pin/repin ceremony) come off until open issues and PRs reach 0; hardening returns later as configuration. Automation Lanes is removing the trust-path hold config. Resume: reopen when the post-zero hardening pass starts.

  7. 8 remaining items

  8. added
    status: confirmedA maintainer confirmed the item is real and in scope; ready to be worked.
    and removed
    needs-owner-decisionAwaiting a human or maintainer judgment call.
    on Oct 31, 2026
  9. added this to the milestone on Oct 31, 2026
  10. added
    host-runNeeds an unattended run on a host; the host runner takes it, not a person or the issue lane.
    on Nov 2, 2026
  11. kyle-sexton commented on Nov 3, 2026

    @kyle-sexton
    MemberAuthor

    Evidence exit met: no App-authored merge reaches a deploy, credential or billing path in azure-iac without the owner's code-owner approval. Author: lane 1 (host run). All read live from the GitHub API on 2026-11-03.

    • A merge needs the code owner. Ruleset azure-iac-code-owner-review (id 24798825) is active on the default branch with require_code_owner_review: true. .github/CODEOWNERS is * @kyle-sexton, so every path, CODEOWNERS and .github/workflows included, needs that account's approval. An App's review does not count as the code owner's.
    • No App can bypass it. The only bypass actor is OrganizationAdmin. Rulesets base (17988999) and trust-root (24475076) also require a pull request and allow no App bypass, and base has no bypass actors at all.
    • No merge starts a deploy. azure-iac-production-deploy.yml has only a workflow_dispatch trigger, its jobs run only on refs/heads/main, and it is the only deploy workflow. The other workflow is pr-require-checks.yml.
    • The agent Apps cannot start a deploy either. melodic-agent has no actions permission and melodic-automation-lanes has actions: read. Both have contents: write, which is what the ruleset above fences. Seven other Apps installed on all repositories hold actions: write (azure-boards, claude, cursor, chatgpt-codex-connector, slack, linear-code, monday-com-github): any of them could dispatch the workflow, but only over reviewed main.
    • Recent history matches. The last 30 azure-iac pull requests were authored by kyle-sexton (19) and Dependabot (11); none by an agent App.

    What this does not cover, both outside the done-when:

    • Agent sessions run under the kyle-sexton login, so a session's approval counts as the code owner's, and that login's own pull requests can use the admin bypass. Those are not App-authored merges; under s10 they are our own actors.
    • The evidence depends on ruleset 24798825 and CODEOWNERS staying as they are. The post-zero hardening pass can reconsider this, as the 2026-10-29 close said. Owner decisions Q15 and Q16 removed path holds, so a .github/trust-path-hold.json is the wrong tool here anyway.

    Closing under the done-when's second item.

  12. kyle-sexton commented on Nov 3, 2026

    @kyle-sexton
    MemberAuthor

    Reopening: lane 1 closed this too early. The evidence shows an App-authored merge needs the code owner's approval, but agent sessions run under the kyle-sexton login, so a session's approval counts as that approval and no person has to look. That means the done-when's "no App-authored merge reaches a deploy, credential or billing path" is not shown. The same login can also start the workflow_dispatch deploy, and the deploy environment's only protection rule is a branch policy. azure-iac can bill the owner, so whether this is acceptable under the current phase is the owner's decision, not lane 1's. Asked in the lane 1 session.

  13. kyle-sexton commented on Nov 3, 2026

    @kyle-sexton
    MemberAuthor

    Decision recorded. Owner, in the lane 1 session, 2026-11-03: "Go with recomended, whatever this recommends", choosing option A: keep the code-owner approval as it is and add a required reviewer on the azure-iac-production environment, so a deploy waits for the owner while code changes keep flowing. Lane 1 checks first whether any unattended deploy depends on that environment, then applies it and closes this issue.

  14. added
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    and removed
    needs-owner-decisionAwaiting a human or maintainer judgment call.
    on Nov 3, 2026
  15. kyle-sexton commented on Nov 3, 2026

    @kyle-sexton
    MemberAuthor

    Option A cannot be applied as written, so this stays open for the owner. Author: lane 1 (host run).

    Required reviewers are not available here. azure-iac is private and the organization is on the Team plan (gh api repos/melodic-software/azure-iac, gh api orgs/melodic-software). GitHub's environment docs say: "If you are on a GitHub Free, GitHub Pro, or GitHub Team plan, required reviewers are only available for public repositories." github-iac ADR 0015 records the same limit for this environment's admin bypass.

    A reviewer would not have done what A intended, for two more reasons.

    • It would hold unattended deploys. azure-iac/AGENTS.md tells the session that merges a change to dispatch operation=auto, and every one of the last 30 runs was dispatched by kyle-sexton, the login sessions use. A reviewer would stop all of them, auto included, until a person approved.
    • The reviewer would be kyle-sexton, the same login, so a session could approve its own deploy unless self-review were also blocked.

    Controls already in place on what can bill the owner:

    • The auto gate. scripts/deploy/check-preview-gate.sh lets Apply run only when every preview step is same, so auto publishes code and changes no Azure resource (azure-iac ADR 0001, Deploy trust).
    • Permission deny rules on operation=up, for both Bash and PowerShell, in the user settings on this host.
    • The auto-mode rules exclude repository, ruleset and environment changes from what a session may do.

    These do not stop a person, and a deny rule is client-side: it holds only where those settings are applied.

    Owner decision needed. The options and the exact reply are in the lane 1 outbox. No environment was changed.

  16. kyle-sexton commented on Nov 3, 2026

    @kyle-sexton
    MemberAuthor

    Owner decision (2026-11-03, lane 1 session): "go w/ recommendations", which selects option 1 from #11044 (comment).

    Option A (a required reviewer on azure-iac-production) cannot be applied: GitHub offers required reviewers on the Team plan only for public repositories, and azure-iac is private (deployments and environments).

    For the throughput phase, the existing controls stand:

    • the auto gate applies only when every preview step is same (azure-iac ADR 0001, Deploy trust);
    • permission rules deny sessions operation=up;
    • auto-mode rules exclude environment changes.

    Closing as not planned. Adding a hold here is hardening, and the owner's standing direction moves hardening to after open issues and PRs reach zero, as a configuration edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: securitySecurity-relevant: vulnerability, hardening, or disclosure follow-up.host-runNeeds an unattended run on a host; the host runner takes it, not a person or the issue lane.status: confirmedA maintainer confirmed the item is real and in scope; ready to be worked.status: readyTriaged, unblocked, and fully specified; eligible to pick up.

    Fields

    No fields configured for Feature.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions