Repository navigation
feat(intake): triage an issue named by a workflow_dispatch run - #774
Conversation
The author gate read github.event.issue.author_association, which a webhook computes with no viewer, so an org member with private membership reads CONTRIBUTOR and every issue they opened was skipped behind a green run. The gate now admits a person whose user id is in the new allowed-author-ids input, with the same malformed-list guards as allowed-bot-sender-ids, and drops the OWNER/MEMBER path. A claude-intake-triage-skipped job now runs when the gate turns an opened issue away: it names the reason in a notice and the run summary and applies the optional skipped-label. Refs: #772 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019bQ8pL7fJgVy7YjQ7wK1Zw
An issue created with a job's GITHUB_TOKEN starts no issues run, so the lane never saw issues a sweep files. A caller can now dispatch the lane with an issue-number input. The run starts only when the dispatching actor's id is in allowed-author-ids (a person) or allowed-bot-sender-ids (a bot), and the lane reads the issue's number and node id from the API, refusing a malformed number or a pull request. Refs: #772 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019bQ8pL7fJgVy7YjQ7wK1Zw
…literal Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019bQ8pL7fJgVy7YjQ7wK1Zw
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019bQ8pL7fJgVy7YjQ7wK1Zw
# Conflicts: # .github/scripts/intake-triage-gate.test.cjs # .github/workflows/intake-triage.yml # README.md
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude finished @kyle-sexton's task in 3m 34s —— View job Code review —
|
|
Claude finished @kyle-sexton's task in 6m 28s —— View job Security review — no findings
This PR adds a What I scrutinized specifically:
GitHub Actions hardening concerns (permission widening, unpinned actions, dangerous triggers) are out of scope here per this lane's contract with zizmor, which the PR description reports clean. |
|
claude-review has reviewed this pull request through 4e8b515; a later push is reviewed from there. |
|
claude-security-review has reviewed this pull request through 4e8b515; a later push is reviewed from there. |
Refs: #772
Summary
Events created with a job's
GITHUB_TOKENstart no workflow run, exceptworkflow_dispatchandrepository_dispatch(GitHub docs, GITHUB_TOKEN: "workflow_dispatchandrepository_dispatchevents always create workflow runs"). The claude-code-plugins lane sweep filesneeds-triageissues with that token, so those issues never reach intake. This lets a caller dispatch the lane for one issue.Stacked on #773 (base
fix/intake-author-id-gate); retarget tomainafter it merges.Fix
Input shape (stable; the sweep-side dispatch will be written against it):
workflow_dispatchwith one input,issue-number(string, decimal digits), passed through as the reusable'sissue-numberinput. Nothing else is read from the dispatch.inputs.issue-numberis non-empty and the dispatching actor's numeric id (github.actor_id) is inallowed-author-ids(non-bot actor) orallowed-bot-sender-ids(actor ending[bot]), with the same malformed-list guards. Dispatching already needs write access; a stranger still cannot start a run. For a sweep that dispatches with itsGITHUB_TOKEN, the caller listsgithub-actions[bot]'s id41898282(or the lanes App's id) inallowed-bot-sender-ids; only that bot's login reachesallowed_bots.Resolve the issuestep reads the issue from the API (issues.get) by the event's number or the validated input (^[1-9][0-9]{0,9}$), refuses a pull request, and supplies the number and node id every later step uses, in place ofgithub.event.issue.*.issuesandworkflow_dispatch; the skipped job also reports a rejected dispatch (notice and summary only, no label).Verification
node --test .github/scripts/*.test.cjs: 437 pass, 0 fail. New cases: a listed person orgithub-actions[bot]dispatch starts a run; an unlisted actor, a person's id in the bot list (and the reverse), a missing actor id, an empty issue number and malformed lists start nothing; the issue is resolved by a validated number.actionlintclean;zizmor --offline: no findings.github.actorisgithub-actions[bot]when aGITHUB_TOKENsends the dispatch, and that claude-code-action's agent mode runs onworkflow_dispatchwithallowed_botsset this way. Both need one live dispatch before the sweep relies on it.Related
GITHUB_TOKEN.🤖 Generated with Claude Code
https://claude.ai/code/session_019bQ8pL7fJgVy7YjQ7wK1Zw