Skip to content

ssh: include sha256 host key hash when supported#5307

Merged
pks-t merged 1 commit intolibgit2:masterfrom
palmin:hash_sha256
Nov 28, 2019
Merged

ssh: include sha256 host key hash when supported#5307
pks-t merged 1 commit intolibgit2:masterfrom
palmin:hash_sha256

Conversation

@palmin
Copy link
Copy Markdown
Contributor

@palmin palmin commented Nov 20, 2019

libssh2 1.9.0 supports SHA-256 host key fingerprints and by checking if LIBSSH2_HOSTKEY_HASH_SHA256 is defined this can be included in git_cert_hostkey when libssh2 supports this without breaking builds when older versions of libssh2 does not.

Copy link
Copy Markdown
Contributor

@tiennou tiennou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos for the PR, but there's a catch… 😉 I'm approving this because it makes sense to add support for it (#5258), but there's a plan to provide a replacement backend (using libssh, see #5225, #5253), and it hit interface issues, so I'd prefer changes to the interface around SSH to be thoroughly discussed before changes are made to it 😜.

@tiennou tiennou mentioned this pull request Nov 20, 2019
@pks-t
Copy link
Copy Markdown
Member

pks-t commented Nov 28, 2019

but there's a plan to provide a replacement backend

Or at least a parallel SSH backend. Not sure if we really want to ditch libssh2 in the near-term future, even if we have libssh as a new (and probably much better) alternative.

I'm 👍 on this PR, as I imagine it to be useful even across different SSH backends. So as @tiennou approved this and didn't mention any specific incompatibilities with the upcoming libssh backend I'm going to merge this.

Thanks a lot for your nice change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants