config: check if we are running in a sandboxed environment#5191
Merged
pks-t merged 1 commit intolibgit2:masterfrom Aug 2, 2019
eaigner:master
Merged
config: check if we are running in a sandboxed environment#5191pks-t merged 1 commit intolibgit2:masterfrom eaigner:master
pks-t merged 1 commit intolibgit2:masterfrom
eaigner:master
Conversation
pks-t
requested changes
Aug 1, 2019
Member
pks-t
left a comment
There was a problem hiding this comment.
This looks sensible to me, thanks a lot!
A test would be lovely, but I assume it's not really feasible except for faking a sandbox environment via manually setting the envvar. I don't think this to be important, though, the code is trivial enough.
Will merge as soon as getenv was replaced by p_getenv.
On macOS the $HOME environment variable returns the path to the sandbox container instead of the actual user $HOME for sandboxed apps. To get the correct path, we have to get it from the password file entry.
pks-t
approved these changes
Aug 2, 2019
Member
|
Thank you, @eaigner! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS the $HOME environment variable returns the path to the sandbox
container instead of the actual user $HOME for sandboxed apps.
To get the correct path, we have to get it from the password file entry.
Closes #5190