Conversation
pks-t
reviewed
Jun 24, 2019
Member
pks-t
left a comment
There was a problem hiding this comment.
Oh, yes please! I didn't see any additions to "deprecated.h", though?
Member
Author
|
Yep, you're right. I added deprecation. |
Member
|
Could we maybe hold this off until my other configuration PRs are merged? I fear conflicts that'd be non-trivial to resolve :/ |
`cvar` is an unhelpful name. Refactor its usage to `configmap` for more clarity.
Member
|
Rebased on latest master to fix conflicts with my own PRs. I've also added the missing "config.h" include to "deprecated.h" |
pks-t
approved these changes
Jul 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cvaris an unhelpful name. Refactor its usage toconfigmapfor more clarity.