Skip to content

git_reset_*: pass parameters as const pointers#4287

Merged
pks-t merged 1 commit intolibgit2:masterfrom
AndreyG:reset/interface-cosmetics
Jul 10, 2017
Merged

git_reset_*: pass parameters as const pointers#4287
pks-t merged 1 commit intolibgit2:masterfrom
AndreyG:reset/interface-cosmetics

Conversation

@AndreyG
Copy link
Copy Markdown
Contributor

@AndreyG AndreyG commented Jun 30, 2017

No description provided.

@pks-t
Copy link
Copy Markdown
Member

pks-t commented Jul 10, 2017

Looks good to me. Adding const to function parameters does not break ABI/API, so that's a non-issue, as well.

Test failures stem from the recent breakage of the master branch on systems using bundled zlib.

@pks-t pks-t merged commit c4c95bf into libgit2:master Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants