Fix proxy auto detect not utilizing callbacks#4097
Merged
carlosmn merged 1 commit intolibgit2:masterfrom May 20, 2017
Merged
Conversation
Member
|
Looks sensible, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using an authenticated proxy and setting proxy_options
typetoGIT_PROXY_AUTO, the credentials, certificate check, and payload are discarded. The implication is users will not be prompted for credentials when proxy type is set to auto. I've fixed this by transferring the credentials, certificate_check, and payload to the new struct when in apply_proxy_config.