fix: present the help center collection by ids on ios#1
Open
khalidos32 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue with the Intercom React Native 4.0.1 SDK on iOS, where collections are not being displayed. This issue has been previously reported by the Intercom engineering team and other users on the Intercom forum: https://forum.intercom.com/s/question/0D55c00006mnnnLCAQ/cant-display-collections-using-intercomreactnative-401-mobile-sdk
After investigating the code, I found that the promise was resolving and that the code was not breaking or crashing. However, I discovered that the logic in the code was incorrect, leading to the issue. As a result, I made changes to the logic to fix the problem. These changes should resolve the collection display issue for all affected users.
Let me know if you have any further questions or if you would like any further help!