updating android to sdk 12.1.1#65
Conversation
There was a problem hiding this comment.
👋 Hey there,
It looks like your PR introduces some terminology we are trying to phase out of our codebase.
For each of the following files, we ask that you update the usage according to the TRU Program Plan.
- example/metro.config.js, line number(s): 2
While this check doesn't block 🚢-ing, please consider making the following suggested terminology changes:
| Old Usage | Updated Usage |
|---|---|
| Whitelist (verb) | Trust |
| Blacklist (verb) | Block |
| Whitelist (noun) | Trusted list |
| Blacklist (noun) | Blocked list |
| Master (DB node) | Primary |
| Slave (replicated DB node) | Replica |
| Slave (non-replicated DB node) | Secondary |
Feel free to reach out to #tru-working-group with any questions.
Let me know what you end up doing after reading this:
- I addressed this comment, it’s fixed now
- I will fix in a subsequent PR
- I will keep the files as-is
|
Hello @niamh-coleman this last update |
|
@niamh-coleman I'm experiencing the same issue as @armouti. Seems to derive from the Android SDK. Specifically version |
|
Hi there. Version 3.0.1 with SDK 12.1.1 does not compile with the same error @armouti reported. Downgrading to 3.0.0 solves the issue. Took me the better part of the day to figure out this was not my fault. |
|
@levynir @jason-vault @armouti |
|
@prithivraj I have successfully upgraded to 3.0.3 and Android built fine. Thanks! |
|
I can confirm that 3.0.3 was built successfully. Thanks! |
No description provided.