Skip to content

updating android to sdk 12.1.1#65

Merged
niamh-coleman merged 1 commit into
mainfrom
niamh/release3_0_1
Apr 26, 2022
Merged

updating android to sdk 12.1.1#65
niamh-coleman merged 1 commit into
mainfrom
niamh/release3_0_1

Conversation

@niamh-coleman

Copy link
Copy Markdown
Contributor

No description provided.

@github-management-service github-management-service left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hey there,
It looks like your PR introduces some terminology we are trying to phase out of our codebase.
For each of the following files, we ask that you update the usage according to the TRU Program Plan.

  • example/metro.config.js, line number(s): 2

While this check doesn't block 🚢-ing, please consider making the following suggested terminology changes:

Old Usage Updated Usage
Whitelist (verb) Trust
Blacklist (verb) Block
Whitelist (noun) Trusted list
Blacklist (noun) Blocked list
Master (DB node) Primary
Slave (replicated DB node) Replica
Slave (non-replicated DB node) Secondary

Feel free to reach out to #tru-working-group with any questions.
Let me know what you end up doing after reading this:

  • I addressed this comment, it’s fixed now
  • I will fix in a subsequent PR
  • I will keep the files as-is

@niamh-coleman niamh-coleman merged commit 517f2fd into main Apr 26, 2022
@armouti

armouti commented Apr 27, 2022

Copy link
Copy Markdown

Hello @niamh-coleman this last update 3.0.1 is causing a build failure on android with the following error:

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:checkDebugDuplicateClasses'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.CheckDuplicatesRunnable
   > Duplicate class com.facebook.flipper.BuildConfig found in modules jetified-flipper-0.75.1-runtime (com.facebook.flipper:flipper:0.75.1) and jetified-flipper-noop-0.138.0-runtime (com.facebook.flipper:flipper-noop:0.138.0)
     Duplicate class com.facebook.flipper.android.AndroidFlipperClient found in modules jetified-flipper-0.75.1-runtime (com.facebook.flipper:flipper:0.75.1) and jetified-flipper-noop-0.138.0-runtime (com.facebook.flipper:flipper-noop:0.138.0)
     Duplicate class com.facebook.flipper.android.diagnostics.FlipperDiagnosticActivity found in modules jetified-flipper-0.75.1-runtime (com.facebook.flipper:flipper:0.75.1) and jetified-flipper-noop-0.138.0-runtime (com.facebook.flipper:flipper-noop:0.138.0)
     Duplicate class com.facebook.flipper.core.FlipperClient found in modules jetified-flipper-0.75.1-runtime (com.facebook.flipper:flipper:0.75.1) and jetified-flipper-noop-0.138.0-runtime (com.facebook.flipper:flipper-noop:0.138.0)
     Duplicate class com.facebook.flipper.core.FlipperPlugin found in modules jetified-flipper-0.75.1-runtime (com.facebook.flipper:flipper:0.75.1) and jetified-flipper-noop-0.138.0-runtime (com.facebook.flipper:flipper-noop:0.138.0)

@jason-vault

Copy link
Copy Markdown

@niamh-coleman I'm experiencing the same issue as @armouti. Seems to derive from the Android SDK. Specifically version 12.1.1 includes Flipper in both feature and debug configurations while 12.0.0 does not.

    \--- io.intercom.android:intercom-sdk:12.1.1
|         +--- io.intercom.android:intercom-sdk-base:12.1.1
|         |    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10
|         |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
|         |    |    \--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.10
|         |    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
|         |    +--- com.facebook.flipper:flipper-noop:0.138.0
|         |    |    \--- com.google.code.findbugs:jsr305:3.0.2

@levynir

levynir commented May 2, 2022

Copy link
Copy Markdown

Hi there. Version 3.0.1 with SDK 12.1.1 does not compile with the same error @armouti reported. Downgrading to 3.0.0 solves the issue. Took me the better part of the day to figure out this was not my fault.

@prithivraj

Copy link
Copy Markdown
Contributor

@levynir @jason-vault @armouti
I've now released v3.0.3 that should fix this issue. Please upgrade let me know if the problem persists.
Thanks!

@Br1an-Boyle Br1an-Boyle deleted the niamh/release3_0_1 branch May 6, 2022 11:54
@jason-vault

Copy link
Copy Markdown

@prithivraj I have successfully upgraded to 3.0.3 and Android built fine. Thanks!

@levynir

levynir commented May 9, 2022

Copy link
Copy Markdown

I can confirm that 3.0.3 was built successfully. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants