Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

tests: add retry conformance test cases and markdown - #594

Merged
cojenco merged 8 commits into
googleapis:mainfrom
cojenco:conftests5-16
Sep 21, 2021
Merged

cojenco merged 8 commits into
googleapis:mainfrom
cojenco:conftests5-16

Conversation

@cojenco

@cojenco cojenco commented Sep 20, 2021

Copy link
Copy Markdown
Contributor
  • Add scenario 5 to test schema: Libraries never retry non-retryable errors for any operations
  • Add scenario 6 to test schema: Libraries behave correctly with a mix of retryable and non-retryable errors
  • Add markdown file
  • Clean up and align json file to match with test schema in conformance-tests

@product-auto-label product-auto-label Bot added the api: storage Issues related to the googleapis/python-storage API. label Sep 20, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 20, 2021
@cojenco
cojenco marked this pull request as ready for review September 20, 2021 23:19
@cojenco
cojenco requested review from a team September 20, 2021 23:19

@unforced unforced left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cojenco
cojenco merged commit 72f22b0 into googleapis:main Sep 21, 2021
@danielduhh

Copy link
Copy Markdown
Contributor

Late review but if you rename the file to README.md, it'll render when you open the directory. @cojenco

cojenco added a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
* add scenario 5 to test schema

* align json with conformance test repo

* add scenario 6 to test schema

* sort import statements

* add md file for retry conf tests

* revise markdown
cojenco added a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
* add scenario 5 to test schema

* align json with conformance test repo

* add scenario 6 to test schema

* sort import statements

* add md file for retry conf tests

* revise markdown
@cojenco
cojenco deleted the conftests5-16 branch December 3, 2021 23:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants