Skip to content
This repository was archived by the owner on Aug 30, 2026. It is now read-only.
This repository was archived by the owner on Aug 30, 2026. It is now read-only.

Types for base_query.py #900

Closed
#1057
Closed
Types for base_query.py#900
#1057
Labels
api: firestoreIssues related to the googleapis/python-firestore API.priority: p2Moderately-important priority. Fix may not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Description

@rgant
rgant
opened on Apr 3, 2024

I cannot use FieldFilter in my projects because it is not typed.

        # It appears that filtering on document ID will not work for collect_group queries.
        # mypy error - Call to untyped function "FieldFilter" in typed context
        # Both FieldFilter & FieldPath have this issue sadly
        .where(filter=FieldFilter(FieldPath.document_id(), '==', program_id)),  # type: ignore[no-untyped-call]

Could the google.cloud.firestore_v1.base_query module be typed?

Activity

  1. product-auto-label
    added
    api: firestoreIssues related to the googleapis/python-firestore API.
    on Apr 3, 2024
  2. gkevinzheng
    added
    priority: p2Moderately-important priority. Fix may not be included in next release.
    priority: p3Desirable enhancement or fix. May not be included in next release.
    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
    and removed
    priority: p2Moderately-important priority. Fix may not be included in next release.
    priority: p3Desirable enhancement or fix. May not be included in next release.
    on Jul 1, 2024

  3. rgant commented on Jan 18, 2025

    @rgant
    rgant
    on Jan 18, 2025
    Author

    Seems like maybe FieldFilter is now typed, but FieldPath is not?

  4. daniel-sanche commented on May 22, 2025

    @daniel-sanche
    daniel-sanche
    on May 22, 2025
    Contributor

    Thanks for raising this, these should be fixed in #1057

  5. daniel-sanche
    closed this as completedin #1057on Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    api: firestoreIssues related to the googleapis/python-firestore API.priority: p2Moderately-important priority. Fix may not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions