Skip to content

feat: expose boot disk type and size for CustomTrainingJob, CustomPythonPackageTrainingJob, and CustomContainerTrainingJob - #602

Merged
gcf-merge-on-green[bot] merged 4 commits into
googleapis:masterfrom
morgandu:mor--expose-disk-spec-for-custom-training
Aug 12, 2021
Merged

gcf-merge-on-green[bot] merged 4 commits into
googleapis:masterfrom
morgandu:mor--expose-disk-spec-for-custom-training

Conversation

@morgandu

@morgandu morgandu commented Aug 11, 2021 •

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<b/193822723> 🦕

  • Change _MachineSpec to _WorkerPoolSpec
    • Add boot_disk_type and boot_disk_size_gb in _MachineSpec and _DistributedTrainingSpec
  • Expose boot_disk_type and boot_disk_size_gb in run with default values of CustomTrainingJob, CustomPythonPackageTrainingJob, and CustomContainerTrainingJob
    • Add in boot_disk_type and boot_disk_size_gb in _CustomTrainingJob._prepare_and_validate_run
  • Expose boot_disk_type and boot_disk_size_gb in CustomJob.from_local_script
    • Update TypeHint for command line arguments args to be passed to the Python task
  • Modify unit tests to for default and overwrite boot disk config

@morgandu
morgandu requested review from a team and sasha-gitg August 11, 2021 01:08
@product-auto-label product-auto-label Bot added the api: aiplatform Issues related to the AI Platform API. label Aug 11, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 11, 2021
@morgandu
morgandu force-pushed the mor--expose-disk-spec-for-custom-training branch from 2b06a22 to 9684547 Compare August 11, 2021 01:08

@sasha-gitg sasha-gitg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for training_jobs.

jobs.CustomJob.from_local_script should also be updated: https://github.com/googleapis/python-aiplatform/blob/master/google/cloud/aiplatform/jobs.py#L1050

fix: typehint for command line arguments to be passed to the Python task
fix: change _MachineSpec to _WorkerPoolSpec
@morgandu
morgandu force-pushed the mor--expose-disk-spec-for-custom-training branch from 9684547 to eb99bd0 Compare August 11, 2021 19:35
@morgandu
morgandu requested a review from sasha-gitg August 11, 2021 19:36

@sasha-gitg sasha-gitg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Morgan!

@sasha-gitg sasha-gitg added the automerge Merge the pull request once unit tests and other checks pass. label Aug 12, 2021
@gcf-merge-on-green
gcf-merge-on-green Bot merged commit 355ea24 into googleapis:master Aug 12, 2021
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 12, 2021
@morgandu
morgandu deleted the mor--expose-disk-spec-for-custom-training branch August 12, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants