BigQuery:Java:Examples Incorrect example for setting expiration for the table

Hi,

There is a small, but a misleading, bug in examples on how to set an expiration for the table in Java.

Relevant code:

Line 33 in fa998ba

Long newExpiration = TimeUnit.MILLISECONDS.convert(1, TimeUnit.DAYS);

Expiration is shown in pure milliseconds of time and not in milliseconds since the epoch like stated in method documentation.

Instead, the example should use:

Long newExpiration = TimeUnit.MILLISECONDS.convert(1, TimeUnit.DAYS) + ZonedDateTime.now(ZoneOffset.UTC).toInstant().toEpochMilli();

or simple

Long newExpiration = TimeUnit.MILLISECONDS.convert(1, TimeUnit.DAYS) + System.currentTimeMillis();

Just try an example and your table will disappear because the expiration date will be in the past

docs(sample): update UpdateTableExpiration sample

Navigation Menu