You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am using duplicate-finder-maven-plugin in my project which has started complaining for duplicate project.properties b/w google-cloud-core & google-cloud-pubsub
`[INFO] Checking test classpath
[WARNING] Found duplicate and different resources in [com.google.cloud:google-cloud-core:1.2.1, com.google.cloud:google-cloud-pubsub:0.20.1-beta]:
[WARNING] project.properties
[WARNING] Found duplicate classes/resources in compile classpath.
[WARNING] Found duplicate and different resources in [com.google.cloud:google-cloud-core:1.2.1, com.google.cloud:google-cloud-pubsub:0.20.1-beta]:
[WARNING] project.properties
[WARNING] Found duplicate classes/resources in runtime classpath.
[WARNING] Found duplicate and different resources in [com.google.cloud:google-cloud-core:1.2.1, com.google.cloud:google-cloud-pubsub:0.20.1-beta]:
[WARNING] project.properties
[WARNING] Found duplicate classes/resources in test classpath.`
I think this is something we should investigate - it may be that META-INF is better than what we do at the moment. I will file a separate issue to track that.
As a temporary workaround: I am not familiar with the plugin, but have you looked at using the ignoredResourcePatterns setting (seen on this page: https://github.com/basepom/duplicate-finder-maven-plugin/wiki). That might help unblock or resolve the warning in the short term.
@garrettjonesgoogle Are we planning on kicking off work to migrate from Maven to Gradle soon? (#1587) If so, this issue may be best handled as part of that transition.
Activity
jakub-bochenski commentedon Sep 7, 2017
I think better place for this
project.propertieswould be underMETA-INF.In fact version is stored there already in
MANIFEST.MFand in Maven descriptor.michaelbausor commentedon Sep 7, 2017
I think this is something we should investigate - it may be that
META-INFis better than what we do at the moment. I will file a separate issue to track that.As a temporary workaround: I am not familiar with the plugin, but have you looked at using the
ignoredResourcePatternssetting (seen on this page: https://github.com/basepom/duplicate-finder-maven-plugin/wiki). That might help unblock or resolve the warning in the short term.jakub-bochenski commentedon Sep 7, 2017
Yes, we have an even better solution, but it's bad practice to have conflicting entries on classpath anyway
danoscarmike commentedon Jan 11, 2018
Ping @michaelbausor - what are next steps here?
michaelbausor commentedon Jan 11, 2018
@garrettjonesgoogle Are we planning on kicking off work to migrate from Maven to Gradle soon? (#1587) If so, this issue may be best handled as part of that transition.
jakub-bochenski commentedon Jan 11, 2018
I just found this has been fixed in db0fdb1
I see it removed the offending sections from multiple poms, though the commit message makes no mention of it
PS. Maybe you could consider using https://github.com/dmurgala/gradle-duplicate-finder-plugin to prevent similiar problems in the future
garrettjonesgoogle commentedon Jan 12, 2018
Correct, this is fixed now. Closing issue.
chore(deps): update dependency com.google.cloud:google-cloud-bigquery…
deps: update dependency com.google.cloud:google-cloud-spanner-bom to …
chore(main): release 2.35.4 (googleapis#2400)
chore(deps): update dependency com.google.cloud:google-cloud-pubsub t…
chore(deps): update dependency com.google.cloud:google-cloud-pubsub t…
chore: deflake trailer skipping test (googleapis#2411)