Fix credential cleanup when env exports are disabled#524
Open
1seal wants to merge 1 commit intogoogle-github-actions:mainfrom
Open
Fix credential cleanup when env exports are disabled#5241seal wants to merge 1 commit intogoogle-github-actions:mainfrom
1seal wants to merge 1 commit intogoogle-github-actions:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
this decouples post-step credentials cleanup from
export_environment_variables.when
create_credentials_file=trueandcleanup_credentials=true, the action now saves the created credentials path withsaveStatein the main step and reads it withgetStatein the post step. this keeps cleanup working even whenexport_environment_variables=false.changes
src/main.tssrc/post.ts, with env var fallbackdist/mainanddist/posttesting
npm testnpm run build