Skip to content

Set trailing comma to none#1

Merged
koddsson merged 2 commits intomasterfrom
set-trailing-comma-to-none
Mar 24, 2020
Merged

Set trailing comma to none#1
koddsson merged 2 commits intomasterfrom
set-trailing-comma-to-none

Conversation

@koddsson
Copy link
Contributor

The default value for trailingComma changes from none to default in prettier 2.0.

This change overwrites the default with none so that we don't have any trailing commas in our codebase when we upgrade to prettier 2.0.

📚 References

https://prettier.io/docs/en/options.html#trailing-commas

@koddsson koddsson requested a review from a team March 24, 2020 10:07
Copy link
Contributor

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like trailing commas, but thats, just like, my opinion, man.

@koddsson
Copy link
Contributor Author

I actually do too but the thinking here was to make as little changes as possible. I'd be down to make the changes if we want to keep trailing commas going forward. They do make diffs a lot cleaner since you don't have to add or remove a comma when adding to a multi-line list.

@muan & @dgraham what do you think?

Copy link

@dgraham dgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the thinking here was to make as little changes as possible.

👍

@koddsson
Copy link
Contributor Author

We can always revisit this later ✨

@koddsson koddsson merged commit 9310c4d into master Mar 24, 2020
@koddsson koddsson deleted the set-trailing-comma-to-none branch March 24, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants