Updating Node.js version to 0.10.21. - #1
Merged
Conversation
Thibaut
added a commit
that referenced
this pull request
Oct 25, 2013
Updating Node.js version to 0.10.21.
Member
|
Thanks! It's actually a bit more complicated than just bumping the version, in that you also need to verify that the scraper works on the updated docs. I'll explain this better in the guidelines/wiki. |
Author
|
Thanks for the info. I did run it locally and poke around a bit and all looked well, before submitting the PR. I'll make sure to include that in the comments next time and perhaps toss it up somewhere for you to review it. I watch Node pretty closely, as I build the packaged for my day job. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nice job man! Very clean, been using devdocs.io for a while now and love it!