feat(auth): enables OIDC auth code flow#549
Merged
lahirumaramba merged 16 commits intofirebase:masterfrom Dec 14, 2021
Merged
Conversation
Contributor
Author
hiranya911
suggested changes
Jun 3, 2021
Contributor
hiranya911
left a comment
There was a problem hiding this comment.
Looks mostly good. Needs a few tweaks to the public API, and a couple of readability nits.
hiranya911
suggested changes
Jun 14, 2021
Contributor
hiranya911
left a comment
There was a problem hiding this comment.
Looks mostly good. Please fix the errors reported by the linter. Plus couple of minor nits on style.
hiranya911
suggested changes
Oct 28, 2021
Contributor
hiranya911
left a comment
There was a problem hiding this comment.
There seem to be some redundant code mistakenly included in the PR. PTAL.
tests/test_auth_providers.py
Outdated
| req = recorder[0] | ||
| assert req.method == 'PATCH' | ||
| mask = ['clientId', 'displayName', 'enabled', 'issuer'] | ||
| mask = ['clientId', 'clientSecret', 'displayName', 'enabled', 'issuer', 'responseType.code', 'responseType.idToken'] |
Member
There was a problem hiding this comment.
The following lines also seem to be triggering more lint errors.
Running linter on module tests
************* Module tests.test_auth_providers
tests/test_auth_providers.py:124:0: C0301: Line too long (111/100) (line-too-long)
tests/test_auth_providers.py:208:0: C0301: Line too long (111/100) (line-too-long)
tests/test_auth_providers.py:228:0: C0301: Line too long (124/100) (line-too-long)
tests/test_auth_providers.py:253:0: C0301: Line too long (127/100) (line-too-long)
Member
|
Thanks @ScruffyProdigy ! |
added 2 commits
December 7, 2021 13:09
lahirumaramba
approved these changes
Dec 9, 2021
kevinthecheung
requested changes
Dec 9, 2021
firebase_admin/_auth_client.py
Outdated
| (optional). A user cannot sign in using a disabled provider. | ||
| client_secret: A string which sets the client secret for the new provider. | ||
| This is required for the code flow. | ||
| code_response_type: Sets whether to enable the code response flow for the new provider. |
kevinthecheung
approved these changes
Dec 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides an option for developers to specify the OAuth response type for their OIDC provider (either one of these can be set:):
RELEASE NOTE: Added support for configuring the authorization code flow for OIDC providers.