Repository navigation
Move where MPK management happens for async - #10550
Merged
alexcrichton merged 1 commit intoApr 8, 2025
Merged
Conversation
Async suspension/resumption has to deal with saving state. Previously this done in both `AsyncWasmCallState` and in `block_on`, meaning that there were two locations doing pretty similar things. The goal of this commit is to put all "restore the state of the world" logic in one location, so the `FiberFuture::resume` function now exclusively has all of the logic for saving/restoring state around execution of a fiber.
abrown
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Async suspension/resumption has to deal with saving state. Previously this done in both
AsyncWasmCallStateand inblock_on, meaning that there were two locations doing pretty similar things. The goal of this commit is to put all "restore the state of the world" logic in one location, so theFiberFuture::resumefunction now exclusively has all of the logic for saving/restoring state around execution of a fiber.