Skip to content

Move where MPK management happens for async - #10550

Merged
alexcrichton merged 1 commit into
bytecodealliance:mainfrom
alexcrichton:better-fiber-management
Apr 8, 2025
Merged

alexcrichton merged 1 commit into
bytecodealliance:mainfrom
alexcrichton:better-fiber-management

Conversation

@alexcrichton

Copy link
Copy Markdown
Member

Async suspension/resumption has to deal with saving state. Previously this done in both AsyncWasmCallState and in block_on, meaning that there were two locations doing pretty similar things. The goal of this commit is to put all "restore the state of the world" logic in one location, so the FiberFuture::resume function now exclusively has all of the logic for saving/restoring state around execution of a fiber.

Async suspension/resumption has to deal with saving state. Previously
this done in both `AsyncWasmCallState` and in `block_on`, meaning that
there were two locations doing pretty similar things. The goal of this
commit is to put all "restore the state of the world" logic in one
location, so the `FiberFuture::resume` function now exclusively has all
of the logic for saving/restoring state around execution of a fiber.
@alexcrichton
alexcrichton requested a review from a team as a code owner April 8, 2025 19:53
@alexcrichton
alexcrichton requested review from fitzgen and removed request for a team April 8, 2025 19:53
@abrown
abrown requested review from abrown and removed request for fitzgen April 8, 2025 21:10
@alexcrichton
alexcrichton added this pull request to the merge queue Apr 8, 2025
Merged via the queue into bytecodealliance:main with commit bdce217 Apr 8, 2025
@alexcrichton
alexcrichton deleted the better-fiber-management branch April 8, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants