Skip to content

Fix validation of named types in instances - #2833

Merged
fitzgen merged 1 commit into
bytecodealliance:mainfrom
alexcrichton:fix-validate-nested-instances
Nov 18, 2026
Merged

fitzgen merged 1 commit into
bytecodealliance:mainfrom
alexcrichton:fix-validate-nested-instances

Conversation

@alexcrichton

Copy link
Copy Markdown
Member

The validator would previously reject otherwise-valid components where exported types are only required to be somewhere within an instance, not necessarily at the same level of what they're being referred to. This moves some list/set management to a different layer of validation to reflect this change.

The validator would previously reject otherwise-valid components where
exported types are only required to be somewhere within an instance, not
necessarily at the same level of what they're being referred to. This
moves some list/set management to a different layer of validation to
reflect this change.

@fitzgen fitzgen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@fitzgen
fitzgen added this pull request to the merge queue Nov 18, 2026
Merged via the queue into bytecodealliance:main with commit d38b9ce Nov 18, 2026
38 checks passed
@alexcrichton
alexcrichton deleted the fix-validate-nested-instances branch November 18, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants