Repository navigation
Conversation
Packages a root defines with nested `package ... { ... }` blocks are
provided inline, so they are no longer resolved from a registry or
written into deps/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages defined with nested
package ... { ... }blocks are provided inline (WIT.md: "so that they don't have to be otherwise resolved via the filesystem or a registry"), so wkg should neither resolve them nor write them intodeps/. Two changes incrates/wasm-pkg-core/src/wit.rs:get_packagesleaves out the packages its group defines: the main package and the nested ones. This fixesfetch,build,publishand a workspacefetch;fetchalso works now when a path-overridden dependency defines nested packages.populate_dependenciesno longer writes the root's nested packages intodeps/, where the next parse would find them defined twice. It parses the root again to learn them, so that the publicgenerate_resolvekeeps its signature.Tests:
test_inline_packages(WIT and wasm output) andtest_build_inline_packages, on a newinline-packagesfixture whose nested package depends on a path-overridden one. All three fail without the change.cargo test --workspace --exclude wasm-pkg-client --exclude wkgcargo clippy --workspace --no-default-features,cargo clippy --workspace --all-features,cargo clippy -p wasm-pkg-core --all-targetscargo fmt --all -- --checkCloses #263