Respect ordering of stream entries#643
Closed
ximus wants to merge 1 commit into
Closed
Conversation
Added streams (require(stream, {entry: true})) are not appended to
the internal `_entries` array like their resolved path conterparts.
_entries is used to determine entry indexing in the ouput bundle.
This commit makes sure entry streams are executed in order in the
ouput bundle.
Contributor
Author
|
Hi all, |
Contributor
Author
There was a problem hiding this comment.
should this be changed to if (opts.entry && id.path) self._entries.push(id.path);?
Contributor
Author
|
I also had to update module-deps so that it upholds the stream.path property of streams down the pipeline. see here: browserify/module-deps#29 |
Contributor
Author
|
Travis is red until the module-deps PR is released and its version is bumped in browserify's package.json |
|
merged in 3.28.1 |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added streams (
require(stream, {entry: true})) are not appended tothe internal
_entriesarray like their resolved path conterparts._entries is used to determine entry indexing in the ouput bundle.
This commit makes sure entry streams are executed in order in the
ouput bundle.