fix typo and test case assert not correct in higher version of JDK#2089
Merged
Conversation
wujimin
reviewed
Nov 27, 2020
| Assert.assertNotNull(null); | ||
| } catch (Exception e) { | ||
| Assert.assertEquals("java.lang.IllegalArgumentException", e.getClass().getName()); | ||
| } |
Contributor
There was a problem hiding this comment.
Throwable throwable = Assertions.catchThrowable(()->SSLManager.createSSLContext(option, custom));
assertThat(throwable).isInstanceOf(IllegalArgumentException.class);异常的assert场景，用assertJ会简单清晰得多
Contributor
Author
There was a problem hiding this comment.
OK . Will try that in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean install -Pitto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.