[WIP] Ensure VM IP is removed from VR DHCP records in dnsmasq.leases after expunge VM

[sureshanaparti]

Description

This PR ensures VM IP is removed from VR DHCP records in dnsmasq.leases after expunge VM.

This also reverts the PR #10183 changes (for #10182), in turn resulting in #11877.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.26%. Comparing base (a7c2a05) to head (7742a9c).
⚠️ Report is 2 commits behind head on 4.20.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #13194      +/-   ##
============================================
- Coverage     16.27%   16.26%   -0.01%     
+ Complexity    13440    13434       -6     
============================================
  Files          5665     5665              
  Lines        500555   500572      +17     
  Branches      60789    60792       +3     
============================================
- Hits          81445    81417      -28     
- Misses       410004   410047      +43     
- Partials       9106     9108       +2     

Flag	Coverage Δ
uitests	4.15% <ø> (ø)
unittests	17.11% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17911

[weizhouapache]

what's the purpose of this ?

[sureshanaparti]

@weizhouapache is it good to have this, to cleanup cache entries? will remove it if not necessary.

[sureshanaparti]

done

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[weizhouapache]

code lgtm

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 17960