Fix Instance Backup related events

[abh1sar]

Description

This PR fixes #11727 #9465

#9465
Backup related events for cmds AssignVirtualMachineToBackupOfferingCmd, RemoveVirtualMachineFromBackupOfferingCmd, CreateBackupScheduleCmd and RestoreVolumeFromBackupAndAttachToVMCmd don't have proper ApiResourceType set.
So they are not currently displayed in Instances' events section.

#11727
If CreateBackupCmd success or fails, it throws a Complete or Error event, but the event doesn't have the Instance Id set as the resource_id.
Due to this, in the Instance's events tab, Start event is present for CreateBackup but Complete or Error events are not present which makes it hard to track failed backups.

This PR fixes both of the above issues.

P.S, Also made changes to replace VM with Instance and added capitalisation of resource names in Event msgs and Exceptions.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

Backup offering Assign and Remove events in Instance's Events tab:

RestoreVolumeFromBackupAndAttachToVM events in Instance's Events tab:

Backup Create Completed and Error events in Instance's Events tab:

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 11.59420% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.09%. Comparing base (5893ba5) to head (180c386).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
...rg/apache/cloudstack/backup/BackupManagerImpl.java	21.62%	29 Missing ⚠️
...ackup/AssignVirtualMachineToBackupOfferingCmd.java	0.00%	6 Missing ⚠️
...i/command/user/backup/CreateBackupScheduleCmd.java	0.00%	6 Missing ⚠️
...kup/RemoveVirtualMachineFromBackupOfferingCmd.java	0.00%	6 Missing ⚠️
...ackup/RestoreVolumeFromBackupAndAttachToVMCmd.java	0.00%	6 Missing ⚠️
...stack/api/command/user/backup/CreateBackupCmd.java	0.00%	4 Missing ⚠️
...rg/apache/cloudstack/backup/NASBackupProvider.java	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               main   #13180    +/-   ##
==========================================
  Coverage     18.09%   18.09%            
- Complexity    16723    16734    +11     
==========================================
  Files          6037     6037            
  Lines        542580   542804   +224     
  Branches      66427    66464    +37     
==========================================
+ Hits          98155    98229    +74     
- Misses       433399   433525   +126     
- Partials      11026    11050    +24     

Flag	Coverage Δ
uitests	3.51% <ø> (ø)
unittests	19.26% <11.59%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[vishesh92]

clgtm

[abh1sar]

@blueorangutan package

[blueorangutan]

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17896

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

[abh1sar]

@blueorangutan package

[blueorangutan]

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17956