Skip to content

Drop isSupported injection, bump rxfire - #3588

Merged
jamesdaniels merged 3 commits into
angular:mainfrom
jamesdaniels:jamesdaniels_rxFireIsSupported
Dec 12, 2024
Merged

Drop isSupported injection, bump rxfire#3588
jamesdaniels merged 3 commits into
angular:mainfrom
jamesdaniels:jamesdaniels_rxFireIsSupported

Conversation

@jamesdaniels

@jamesdaniels jamesdaniels commented Dec 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Bump rxfire dep
  • Drop isSupported inject in favor of PLATFORM_ID test
  • Analytics is technically isPlatformBrowser rather than !isPlatformServer, prolly no diff

@jamesdaniels
jamesdaniels merged commit 6b1b0ca into angular:main Dec 12, 2024
@jamesdaniels
jamesdaniels deleted the jamesdaniels_rxFireIsSupported branch December 12, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jamesdaniels