Skip to content

feat(analytics): Bunch of analytics & screen tracking improvements - #2654

Merged
jamesdaniels merged 3 commits into
masterfrom
610-analytics
Nov 14, 2020
Merged

feat(analytics): Bunch of analytics & screen tracking improvements#2654
jamesdaniels merged 3 commits into
masterfrom
610-analytics

Conversation

@jamesdaniels

@jamesdaniels jamesdaniels commented Nov 14, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Better handle lazy routes
  • Better handle nested routes
  • Better handle nested & lazy routes
  • Handle multiple outlets correctly
  • Handle multiple outlets that share the same lazy components (this was tricky)
  • NO LONGER USING INTERNAL APIS OR REQUIRING ANNOTATIONS!!!! 🎉 😄
  • APP_NAME and APP_VERSION should be working now...
  • AngularFireAnalytics now gets it's measurementId from Analytics rather than your config, there's an edge case where this can change out from underneath you, which the JS SDK handles
  • Got DEBUG_MODE working again

@jamesdaniels jamesdaniels changed the title feat(analytics): Bunch of ScreenTrackingService improvements feat(analytics): Bunch of analytics & screen tracking improvements Nov 14, 2020
@jamesdaniels
jamesdaniels merged commit b00e14b into master Nov 14, 2020
@jamesdaniels
jamesdaniels deleted the 610-analytics branch November 14, 2020 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jamesdaniels @googlebot