Skip to content

6.0.5 various fixes - #2633

Merged
jamesdaniels merged 8 commits into
masterfrom
605_fixes
Nov 3, 2020
Merged

jamesdaniels merged 8 commits into
masterfrom
605_fixes

Conversation

@jamesdaniels

Copy link
Copy Markdown
Contributor

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Code sample

@jamesdaniels jamesdaniels changed the title 605 fixes 6.0.5 various fixes Nov 3, 2020
@google-cla google-cla Bot added the cla: yes label Nov 3, 2020
Comment thread package.json Resolved
@jamesdaniels

Copy link
Copy Markdown
Contributor Author

@alx-andru I was inspired by your work in #2608, thanks! I decided to implement the API as null properties on the .prototype, I generate the properties via ts-transformer-keys at build time. It's a little magic but it seems to work well enough.

jamesdaniels and others added 3 commits November 3, 2020 00:24
@google-cla

This comment has been minimized.

@google-cla google-cla Bot removed the cla: yes label Nov 3, 2020
@googlebot

This comment has been minimized.

@google-cla

google-cla Bot commented Nov 3, 2020

Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot

Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@jamesdaniels
jamesdaniels merged commit af238cd into master Nov 3, 2020
@jamesdaniels
jamesdaniels deleted the 605_fixes branch November 3, 2020 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants