Repository navigation
feat(messaging): AngularFireMessaing - #1749
Merged
Merged
Conversation
jamesdaniels
reviewed
Aug 7, 2018
|
|
||
| this.requestPermission = requestPermission(this.messaging); | ||
|
|
||
| this.getToken = from(this.messaging.getToken()); |
Contributor
There was a problem hiding this comment.
We should make this a single IMO
Contributor
There was a problem hiding this comment.
Err, that's a Promise hance a single... nevermind.
|
|
||
| this.getToken = from(this.messaging.getToken()); | ||
|
|
||
| this.tokenChanges = new Observable(subscriber => { |
Contributor
There was a problem hiding this comment.
So now that I'm playing with this I'm not sure I like this API. I think I'd prefer:
this.tokenChanges => from(this.messaging.onTokenRefresh);
this.token => this.getToken.pipe(concat(this.tokenChanges))
Thoughts?
jamesdaniels
reviewed
Aug 7, 2018
|
|
||
| } | ||
|
|
||
| deleteToken(token: string) { |
Contributor
There was a problem hiding this comment.
Hmmm... not sure about this API either, how about
this.deleteToken = this.getToken.pipe(
mergeMap(t => t ? this.messaging.deleteToken(t) : empty() )
)
jamesdaniels
reviewed
Aug 7, 2018
| constructor(public app: FirebaseApp) { | ||
| this.messaging = app.messaging(); | ||
|
|
||
| this.requestPermission = requestPermission(this.messaging); |
jamesdaniels
reviewed
Aug 7, 2018
| this.messaging.onMessage(subscriber); | ||
| }); | ||
|
|
||
| this.requestToken = this.requestPermission.pipe( |
Contributor
There was a problem hiding this comment.
We should catch the requestPermission exception and complete with null
jamesdaniels
approved these changes
Aug 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AngularFireMessaging
This is a WIP, but here is the current API surface.