You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Query: First argument passed to startAt(), endAt(), or equalTo() cannot be an object. #900
@vkniazeu If I mentioned on Stack Overflow that support for the optional key for equalTo and endAt was in verion 2.0.0-beta.8, I was mistaken. The changes were introduced in this commit: e146492
Which is two commits after 2.0.0-beta.8. So the changes have been merged into master, but they are not in a published release. Apologies for any confusion I've caused.
@cartant , thank you for a quick reply!
I did find #838 and erroneously commented there (comment deleted) to ask about this feature.
But I wasn't going by any of your comments per se, but rather by the footnote 1 at https://github.com/angular/angularfire2/blob/master/docs/4-querying-lists.md.
It clearly suggests that I can specify the key parameter to equalTo.
Perhaps it's best to update that footnote to only apply to startAt until the feature is released, what do you think?
@vkniazeu Currently, the documentation is essentially whatever is in master and, as the PR that was merged included the code changes, the tests and the documentation, it's reflected in what you see on the GitHub site. If/when the documentation is published to a separate site - upon the publishing of a release - this would be less of a problem, but, at the moment, it is what it is.
@cartant , got it. I was treating the docs as something that was updated post release.
In any case, thank you for the PR and looking forward to using the feature in my code when it's released.
This issue is resolved then.
@vkniazeu No worries. For what it's worth, when I look around in GitHub repos for source and docs I often make a point of selecting the branch that corresponds with the latest release - or the release that I'm using - to see the source and docs as they were at the time.
Activity
cartant commentedon Apr 13, 2017
@vkniazeu If I mentioned on Stack Overflow that support for the optional
keyforequalToandendAtwas in verion 2.0.0-beta.8, I was mistaken. The changes were introduced in this commit: e146492Which is two commits after 2.0.0-beta.8. So the changes have been merged into master, but they are not in a published release. Apologies for any confusion I've caused.
vkniazeu commentedon Apr 13, 2017
@cartant , thank you for a quick reply!
I did find #838 and erroneously commented there (comment deleted) to ask about this feature.
But I wasn't going by any of your comments per se, but rather by the footnote 1 at https://github.com/angular/angularfire2/blob/master/docs/4-querying-lists.md.
It clearly suggests that I can specify the
keyparameter toequalTo.Perhaps it's best to update that footnote to only apply to
startAtuntil the feature is released, what do you think?cartant commentedon Apr 13, 2017
@vkniazeu Currently, the documentation is essentially whatever is in master and, as the PR that was merged included the code changes, the tests and the documentation, it's reflected in what you see on the GitHub site. If/when the documentation is published to a separate site - upon the publishing of a release - this would be less of a problem, but, at the moment, it is what it is.
vkniazeu commentedon Apr 13, 2017
@cartant , got it. I was treating the docs as something that was updated post release.
In any case, thank you for the PR and looking forward to using the feature in my code when it's released.
This issue is resolved then.
cartant commentedon Apr 13, 2017
@vkniazeu No worries. For what it's worth, when I look around in GitHub repos for source and docs I often make a point of selecting the branch that corresponds with the latest release - or the release that I'm using - to see the source and docs as they were at the time.
lucasmafra commentedon Apr 24, 2017
please, I need this feature for now! How can I play with the latest changes in master?