Repository navigation
fix(@angular/build): always use AOT when extracting i18n messages - #34303
Merged
Merged
Conversation
with `aot: false` on build target, extraction built app in JIT and template messages never got into extracted file webpack extraction alredy forced AOT, application extraction now does same
There was a problem hiding this comment.
Code Review
This pull request ensures that Ahead-of-Time (AOT) compilation is explicitly enabled (buildOptions.aot = true) during i18n message extraction in both the Angular build and Angular DevKit builders. This guarantees that template messages are correctly extracted even if the build target disables AOT in the configuration. An end-to-end test has been added to verify this behavior. There are no review comments, so I have no feedback to provide.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
Issue Number: #31227
When build target has
aot: false,extract-i18nbuilds app in JIT, so templatei18nmessages never turn into$localizecalls and are missing from extracted file withot any warningWebpack extraction always forced
aot: true, so this only shows up with application builderWhat is the new behavior?
Application extraction in
@angular/buildand@angular-devkit/build-angularforcesaot: true, same as webpack oneNew case in
extract-ivy.tssetsaot: falseon build target and still expects template message, it fails on mainDoes this PR introduce a breaking change?
Other information
If overiding user's
aotsilently is not wanted, I can log warning or error foraot: falseinsteadCloses: #31227