Include synthio.Biquad methods within audiofilters.Filter#9754
Include synthio.Biquad methods within audiofilters.Filter#9754relic-se wants to merge 4 commits into
synthio.Biquad methods within audiofilters.Filter#9754Conversation
|
I've changed this PR to a draft, because I am currently contemplating the possibility of implementing multiple |
|
I've decided to have the new methods simply return the I've also added a deprecation notice in correspondence with #9756. However, this does cause an error in the docs because that PR hasn't been merged yet and I don't plan on doing any more work on this PR. This addition may be entirely unnecessary at this point, so it is alright by me to reject the PR. |
|
PR no longer needed with merge of #9756 |
This is a minor modification to the previously merged PR #9744.
This modification adds the following methods to the
audiofilters.Filterclass:audiofilters.Filter.low_pass_filteraudiofilters.Filter.high_pass_filteraudiofilters.Filter.bass_pass_filterThese new methods help facilitate the generation of
synthio.Biquadobjects for the filter effect without requiring an instance ofsynthio.Synthesizer. It also ensures that the sample rate used for the filter calculations matches the effect.Here is a modified version of the example provided in #9744 with this change in place:
The only consideration I have is whether or not to automatically update the filter internally or return the
synthio.Biquadobject to set manually. This is how that implementation would look like: